Skip to content

Fix flaky BrowserComponentScreenshotTest race condition and timing #4276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shai-almog merged 1 commit into from
Dec 16, 2025
Merged

Fix flaky BrowserComponentScreenshotTest race condition and timing #4276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions .../java/com/codenameone/examples/hellocodenameone/tests/BrowserComponentScreenshotTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,39 @@

public class BrowserComponentScreenshotTest extends BaseTest {
private BrowserComponent browser;
private boolean loaded;
private Runnable readyRunnable;
private Form form;

@Override
public boolean runTest() throws Exception {
if (!BrowserComponent.isNativeBrowserSupported()) {
done();
return true;
}
Form form = createForm("Browser Test", new BorderLayout(), "BrowserComponent");
form = createForm("Browser Test", new BorderLayout(), "BrowserComponent");
browser = new BrowserComponent();
browser.addWebEventListener(BrowserComponent.onLoad, evt -> {
loaded = true;
checkReady();
});
browser.setPage(buildHtml(), null);
form.add(BorderLayout.CENTER, browser);
form.show();
return true;
}

@Override
protected void registerReadyCallback(Form parent, final Runnable run) {
browser.addWebEventListener(BrowserComponent.onLoad, evt ->
UITimer.timer(200, false, parent, run));
this.readyRunnable = run;
checkReady();
}

private void checkReady() {
if (loaded && readyRunnable != null) {
UITimer.timer(500, false, form, readyRunnable);
readyRunnable = null;
}
}

private static String buildHtml() {
Expand Down
Loading