fix: fix PR preview delete #110
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Preview binaries are ready! To test with modules: |
matifali
reviewed
Oct 2, 2025
johnstcn
reviewed
Oct 6, 2025
Comment on lines
+20
to
+26
| - name: Download cleanup signal | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: cleanup-signal | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| run-id: ${{ github.event.workflow_run.id }} | ||
|
|
There was a problem hiding this comment.
Can you explain the significance of this artifact?
There was a problem hiding this comment.
@johnstcn gh release create/delete/update commands don't work from a PR from a fork as the GITHUB_TOKEN doesn't have enough access.
eg: Check the second step here
https://github.com/coder/agentapi/actions/runs/18270399274/job/52011769517
That's why I had to break this into two parts (similar to the pr release preview).
So now, the signal is created when a PR is closed and then the actual release operations are done on the coder/agentapi repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.