-
Notifications
You must be signed in to change notification settings - Fork 79
fix: fix PR preview delete #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
35C4n0r
wants to merge
1
commit into
coder:main
Choose a base branch
from
35C4n0r:fix-delete-preview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+59
−13
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
name: PR Preview Cleanup Signal | ||
|
||
on: | ||
pull_request: | ||
types: [closed] | ||
|
||
|
||
jobs: | ||
cleanup-signal: | ||
name: Signal Cleanup | ||
runs-on: ubuntu-latest | ||
permissions: | ||
contents: write | ||
|
||
steps: | ||
- name: Save PR number for cleanup | ||
run: | | ||
mkdir -p ./cleanup | ||
echo ${{ github.event.pull_request.number }} > ./cleanup/number | ||
|
||
- name: Upload cleanup signal | ||
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 | ||
with: | ||
name: cleanup-signal | ||
path: cleanup/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,42 @@ | ||
name: PR Preview Cleanup | ||
|
||
on: | ||
pull_request: | ||
types: [closed] | ||
workflow_run: | ||
workflows: ["PR Preview Cleanup Signal"] | ||
types: | ||
- completed | ||
|
||
permissions: | ||
contents: write | ||
contents: write | ||
pull-requests: write | ||
|
||
jobs: | ||
cleanup: | ||
name: Delete PR Release | ||
runs-on: ubuntu-latest | ||
cleanup: | ||
name: Delete PR Release | ||
runs-on: ubuntu-latest | ||
if: ${{ github.event.workflow_run.conclusion == 'success' }} | ||
|
||
steps: | ||
- name: Delete PR Release | ||
env: | ||
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
RELEASE_TAG: 'agentapi_${{ github.event.pull_request.number }}' | ||
run: | | ||
gh release delete "$RELEASE_TAG" --cleanup-tag --yes --repo ${{ github.repository }} || true | ||
steps: | ||
- name: Download cleanup signal | ||
uses: actions/download-artifact@v4 | ||
with: | ||
name: cleanup-signal | ||
github-token: ${{ secrets.GITHUB_TOKEN }} | ||
run-id: ${{ github.event.workflow_run.id }} | ||
|
||
- name: Read PR number | ||
id: pr | ||
run: echo "number=$(cat number)" >> "${GITHUB_OUTPUT}" | ||
|
||
- name: Delete PR Release | ||
env: | ||
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
RELEASE_TAG: "agentapi_${{ steps.pr.outputs.number }}" | ||
run: | | ||
# Check if release exists and delete it | ||
if gh release view "$RELEASE_TAG" --repo ${{ github.repository }} &>/dev/null; then | ||
echo "Deleting release $RELEASE_TAG" | ||
gh release delete "$RELEASE_TAG" --cleanup-tag --yes --repo ${{ github.repository }} | ||
else | ||
echo "Release $RELEASE_TAG does not exist, nothing to delete" | ||
fi |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the significance of this artifact?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnstcn
gh release
create/delete/update commands don't work from a PR from a fork as theGITHUB_TOKEN
doesn't have enough access.eg: Check the second step here
https://github.com/coder/agentapi/actions/runs/18270399274/job/52011769517
That's why I had to break this into two parts (similar to the pr release preview).
So now, the signal is created when a PR is closed and then the actual release operations are done on the
coder/agentapi
repo.