fix: update namespace for coder-labs template #191
Conversation
| description: Run Coder Tasks on Docker with an example application | ||
| icon: ../../../../.icons/tasks.svg | ||
| maintainer_github: coder | ||
| maintainer_github: coder-labs |
There was a problem hiding this comment.
Should we instead remove this line? we do not have a coder-labs github org
Both coder and coder-labs have the same GitHub account, coder.
There was a problem hiding this comment.
We could use coder-contrib if needed 🤷🏼
There was a problem hiding this comment.
I just made https://github.com/coder-contrib more official.
However, I am confused why this is being used as the namespace and not the folder name under registry/. For long-term consideration
There was a problem hiding this comment.
This is likely a bug in the build process, and your assumption is right that the namespace should be the directory.
There was a problem hiding this comment.
That's a good workaround for now. I am not sure, though if it work. We have yet to test a workflow where the namespace and the maintainer_github are different.
There was a problem hiding this comment.
Yeah, I just looked through the registry-server repo, and somehow, we really dropped the ball. In all our updates to the build step, we never updated the frontend payloads to actually get the namespace.
I always assumed that we just kept the maintainer_github field named the same way for backwards compatibility, but reworked how it worked behind the scenes to respect the new namespace system. Turns out, that part of the build step was never updated
There was a problem hiding this comment.
I legitimately think that keeping the maintainer_github field, and just swapping the value to coder-labs is the least risky way we can update things right now
There was a problem hiding this comment.
Then I can spend today actually getting something in place to make the fields unnecessary (even though it should've been in place back in April/May)
There was a problem hiding this comment.
Ok. Lets do this then to get the template out. And we can fix the build process meanwhile.
3 participants
Description
This PR updates the
maintainer_githubfield for the new Coder Labs template to use the value ofcoder-labs. This shouldn't be necessary (maintainer_githubshould be deprecated), but something is off with our build step.Type of Change
Testing & Validation
bun test)bun run fmt)Related Issues
None