Skip to content

fix: update namespace for coder-labs template #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

fix: update namespace for coder-labs template #191

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff40bdf
fix: update namespace for coder-labs template
Parkreiner Jul 7, 2025
f8cbcf1
Merge branch 'main' into mes/labs-patch
Parkreiner Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion registry/coder-labs/templates/tasks-docker/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
display_name: Tasks on Docker
description: Run Coder Tasks on Docker with an example application
icon: ../../../../.icons/tasks.svg
maintainer_github: coder
maintainer_github: coder-labs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we instead remove this line? we do not have a coder-labs github org

Both coder and coder-labs have the same GitHub account, coder.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use coder-contrib if needed 🤷🏼

Copy link
Member

@bpmct bpmct Jul 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made https://github.com/coder-contrib more official.

However, I am confused why this is being used as the namespace and not the folder name under registry/. For long-term consideration

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely a bug in the build process, and your assumption is right that the namespace should be the directory.

Copy link
Member

@matifali matifali Jul 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good workaround for now. I am not sure, though if it work. We have yet to test a workflow where the namespace and the maintainer_github are different.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just looked through the registry-server repo, and somehow, we really dropped the ball. In all our updates to the build step, we never updated the frontend payloads to actually get the namespace.

I always assumed that we just kept the maintainer_github field named the same way for backwards compatibility, but reworked how it worked behind the scenes to respect the new namespace system. Turns out, that part of the build step was never updated

Copy link
Member Author

@Parkreiner Parkreiner Jul 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I legitimately think that keeping the maintainer_github field, and just swapping the value to coder-labs is the least risky way we can update things right now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I can spend today actually getting something in place to make the fields unnecessary (even though it should've been in place back in April/May)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Lets do this then to get the template out. And we can fix the build process meanwhile.

verified: false
tags: [docker, container, ai, tasks]
---
Expand Down