fix(devcontainers-cli): allow yarn to install when packageManager not yarn
#287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot `yarn` On our dogfood box, we fail to install `@devcontainers/cli` with `yarn` because our agent directory `/home/coder/coder` contains a `package.json` with `packageManager` being set to `pnpm`. This change instead ensures to run the script inside the `$CODER_SCRIPT_DATA_DIR` so that we don't read a `package.json` and cause things to break.
mafredri
approved these changes
Aug 4, 2025
Parkreiner
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On our dogfood workspaces, we fail to install
@devcontainers/cliwithyarnbecause our agent directory/home/coder/codercontains apackage.jsonwithpackageManagerbeing set topnpm. This change instead ensures to runyarn global addinside the$CODER_SCRIPT_DATA_DIRso that we don't read apackage.jsonand cause things to break.Type of Change
Module Information
Path:
registry/coder/modules/devcontainers-cliNew version:
v1.0.32Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun run fmt)Related Issues
None