Skip to content

fix(devcontainers-cli): allow yarn to install when packageManager not yarn #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 4, 2025
+12 −2
Merged

fix(devcontainers-cli): allow yarn to install when packageManager not yarn #287

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
11ffff2
fix(devcontainers-cli): allow yarn to install when `packageManager` n…
DanielleMaywood Aug 4, 2025
89f57b6
chore: drive by fixes
DanielleMaywood Aug 4, 2025
ce25292
fix: `sh` -> `bash`
DanielleMaywood Aug 4, 2025
8816351
test: install bash and execute with bash
DanielleMaywood Aug 4, 2025
f08f23e
chore: revert back to `sh` instead of `bash`, `cd` at top-level
DanielleMaywood Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion registry/coder/modules/devcontainers-cli/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ The devcontainers-cli module provides an easy way to install [`@devcontainers/cl
```tf
module "devcontainers-cli" {
source = "registry.coder.com/coder/devcontainers-cli/coder"
version = "1.0.31"
version = "1.0.32"
agent_id = coder_agent.example.id
}
```
4 changes: 4 additions & 0 deletions registry/coder/modules/devcontainers-cli/main.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,17 @@ const executeScriptInContainerWithPackageManager = async (

console.log(path);

await execContainer(id, [shell, "-c", "mkdir -p /tmp/coder-script-data"]);

const resp = await execContainer(
id,
[shell, "-c", instance.script],
[
"--env",
"CODER_SCRIPT_BIN_DIR=/tmp/coder-script-data/bin",
"--env",
"CODER_SCRIPT_DATA_DIR=/tmp/coder-script-data",
"--env",
`PATH=${path}:/tmp/coder-script-data/bin`,
],
);
Expand Down
5 changes: 4 additions & 1 deletion registry/coder/modules/devcontainers-cli/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ install() {
fi
pnpm add -g @devcontainers/cli
elif [ "$PACKAGE_MANAGER" = "yarn" ]; then
yarn global add @devcontainers/cli --prefix "$(dirname "$CODER_SCRIPT_BIN_DIR")"
# We want to cd into `$CODER_SCRIPT_DATA_DIR` as the current directory
# might contain a `package.json` with `packageManager` set to something
# other than `yarn`. When this happens, `yarn global add` will fail to install.
cd "$CODER_SCRIPT_DATA_DIR" && yarn global add @devcontainers/cli --prefix "$(dirname "$CODER_SCRIPT_BIN_DIR")"
fi
}

Expand Down