-
Notifications
You must be signed in to change notification settings - Fork 24
Make test-with-coverage.yml workflow run in push events to master branch #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Make test-with-coverage.yml workflow run in push events to master branch #511
Conversation
WalkthroughThe pull request adds a push trigger to the GitHub Actions workflow for the master branch while ignoring tagged pushes. The workflow now executes on both pull requests and pushes to master, expanding its event-driven execution beyond the existing pull request trigger. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/test-with-coverage.yml:
- Around line 5-9: The tags-ignore pattern currently set to '*.*' only matches
tags with a dot; update the workflow key tags-ignore under the push trigger to
use '*' instead of '*.*' so all tag pushes are ignored (edit the YAML entry
tags-ignore: to tags-ignore: - '*' preserving indentation and list format).
| push: | ||
| branches: | ||
| - master | ||
| tags-ignore: | ||
| - '*.*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`tags-ignore: '.' won’t ignore all tag pushes.
This only matches tags containing a dot (e.g., v1.2). If the goal is to ignore all tags, use '*'.
✅ Suggested fix
tags-ignore:
- - '*.*'
+ - '*'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| push: | |
| branches: | |
| - master | |
| tags-ignore: | |
| - '*.*' | |
| push: | |
| branches: | |
| - master | |
| tags-ignore: | |
| - '*' |
🤖 Prompt for AI Agents
In @.github/workflows/test-with-coverage.yml around lines 5 - 9, The tags-ignore
pattern currently set to '*.*' only matches tags with a dot; update the workflow
key tags-ignore under the push trigger to use '*' instead of '*.*' so all tag
pushes are ignored (edit the YAML entry tags-ignore: to tags-ignore: - '*'
preserving indentation and list format).



Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.