Skip to content

Make test-with-coverage.yml workflow run in push events to master branch #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrosental merged 1 commit into from
Jan 29, 2026
+5 −0
Merged

Make test-with-coverage.yml workflow run in push events to master branch #511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/test-with-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ name: test-with-coverage
on:
pull_request:
branches: [ master ]
push:
branches:
- master
tags-ignore:
- '*.*'
Comment on lines +5 to +9
Copy link

@coderabbitai coderabbitai bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

`tags-ignore: '.' won’t ignore all tag pushes.

This only matches tags containing a dot (e.g., v1.2). If the goal is to ignore all tags, use '*'.

✅ Suggested fix 
     tags-ignore:
-      - '*.*'
+      - '*'
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
push:
branches:
- master
tags-ignore:
- '*.*'
push:
branches:
- master
tags-ignore:
- '*'
🤖 Prompt for AI Agents 
In @.github/workflows/test-with-coverage.yml around lines 5 - 9, The tags-ignore
pattern currently set to '*.*' only matches tags with a dot; update the workflow
key tags-ignore under the push trigger to use '*' instead of '*.*' so all tag
pushes are ignored (edit the YAML entry tags-ignore: to tags-ignore: - '*'
preserving indentation and list format).


jobs:
test:
Expand Down
Loading