Skip to content

Conversation

@Oaphi
Copy link
Member

@Oaphi Oaphi commented Aug 2, 2025

closes #1717

Also cleans up the controller a little bit and documents instance variables / variables expected by the /close_reasons/form view just in case

@codecov
Copy link

codecov bot commented Aug 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.72%. Comparing base (78c1f6e) to head (e9f19f2).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files
Components Coverage Δ
controllers 69.06% <100.00%> (+0.10%) ⬆️
helpers 79.01% <ø> (ø)
jobs 48.57% <ø> (ø)
models 85.90% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Oaphi Oaphi added this to the v0.12.3 milestone Aug 3, 2025
@ArtOfCode- ArtOfCode- merged commit 7518743 into develop Aug 4, 2025
18 of 22 checks passed
@ArtOfCode- ArtOfCode- deleted the 0valt/1717/close-reasons branch August 4, 2025 12:00
@Oaphi Oaphi mentioned this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cancelling adding a new close reason should not always redirect back to global reasons

2 participants