WIP: Support cluster names in cofide svids

[alec-w]

Part of https://github.com/cofide/cofide/issues/175

Cluster names in cofide svids (specifically the observer) are needed to support multi-cluster trust zones.

Superseded by #97 - will close once merged

[gemini-code-assist]

Summary of Changes

Hello @alec-w, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Envoy configuration to include cluster names within the SPIFFE ID (SVID) validation regex for cofide-agent and cofide-observer. This change is essential for establishing multi-cluster trust zones, allowing these services to operate securely across distributed environments.

Highlights

• SVID Regex Update: Modified the regular expressions for cofide-agent and cofide-observer SPIFFE IDs in the Envoy configuration to incorporate cluster names.
• Multi-Cluster Support: Enabled the system to support multi-cluster trust zones by allowing cluster-specific SVIDs, particularly for the observer.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• charts/cofide-connect/templates/configmap-envoy.yaml
  • Updated the safe_regex patterns for cofide-agent and cofide-observer SVIDs to incorporate a cluster/[\w-]+ segment, enabling cluster-specific identification.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the Envoy configuration to support cluster names in SPIFFE SVIDs for cofide-agent and cofide-observer, which is necessary for multi-cluster trust zones. The changes correctly add a cluster name component to the SVID validation regex.

My review includes suggestions to make the regex for the cluster name more restrictive to align with common naming conventions and prevent potentially invalid names.

Additionally, I noticed that a similar regex for cofide-agent at line 54 in charts/cofide-connect/templates/configmap-envoy.yaml (within the connect_xds_api filter chain) has not been updated. If cofide-agent SVIDs will now always contain a cluster name, this could lead to validation failures for clients connecting to the XDS endpoint. You may want to update that regex as well to ensure consistency.

[gemini-code-assist]

The regex for matching the cluster name, [\w-]+, is quite permissive. It allows names that start or end with a hyphen or underscore (e.g., -cluster or cluster_), which can be problematic if these names are used in contexts with stricter validation like DNS. It's better to use a more restrictive regex that enforces a standard naming convention, disallowing leading or trailing separators.

                                regex: spiffe://[^/]+/cluster/[a-zA-Z0-9](?:[a-zA-Z0-9_-]*[a-zA-Z0-9])?/ns/cofide/sa/cofide-agent

[gemini-code-assist]

The regex for matching the cluster name, [\w-]+, is quite permissive. It allows names that start or end with a hyphen or underscore (e.g., -cluster or cluster_), which can be problematic if these names are used in contexts with stricter validation like DNS. It's better to use a more restrictive regex that enforces a standard naming convention, disallowing leading or trailing separators.

                                regex: spiffe://[^/]+/cluster/[a-zA-Z0-9](?:[a-zA-Z0-9_-]*[a-zA-Z0-9])?/ns/cofide/sa/cofide-observer