Skip to content

WIP: Support cluster names in cofide svids #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alec-w wants to merge 1 commit into from
Closed

WIP: Support cluster names in cofide svids #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/cofide-connect/templates/configmap-envoy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,15 +230,15 @@ data:
- san_type: URI
matcher:
safe_regex:
regex: spiffe://[^/]*/ns/cofide/sa/cofide-agent
regex: spiffe://[^/]+/cluster/[\w-]+/ns/cofide/sa/cofide-agent
Copy link

@gemini-code-assist gemini-code-assist bot Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The regex for matching the cluster name, [\w-]+, is quite permissive. It allows names that start or end with a hyphen or underscore (e.g., -cluster or cluster_), which can be problematic if these names are used in contexts with stricter validation like DNS. It's better to use a more restrictive regex that enforces a standard naming convention, disallowing leading or trailing separators.

                                regex: spiffe://[^/]+/cluster/[a-zA-Z0-9](?:[a-zA-Z0-9_-]*[a-zA-Z0-9])?/ns/cofide/sa/cofide-agent

- san_type: URI
matcher:
safe_regex:
regex: spiffe://[^/]*/spire/server
- san_type: URI
matcher:
safe_regex:
regex: spiffe://[^/]*/ns/cofide/sa/cofide-observer
regex: spiffe://[^/]+/cluster/[\w-]+/ns/cofide/sa/cofide-observer
Copy link

@gemini-code-assist gemini-code-assist bot Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The regex for matching the cluster name, [\w-]+, is quite permissive. It allows names that start or end with a hyphen or underscore (e.g., -cluster or cluster_), which can be problematic if these names are used in contexts with stricter validation like DNS. It's better to use a more restrictive regex that enforces a standard naming convention, disallowing leading or trailing separators.

                                regex: spiffe://[^/]+/cluster/[a-zA-Z0-9](?:[a-zA-Z0-9_-]*[a-zA-Z0-9])?/ns/cofide/sa/cofide-observer

validation_context_sds_secret_config:
name: ALL
sds_config:
Expand Down
Loading