Support disabling of cluster role creation#26
Conversation
Summary of ChangesHello @alec-w, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the flexibility of the SPIRE server Helm chart by introducing a new configuration option to disable the automatic creation of Kubernetes ClusterRoles. This change is particularly beneficial for advanced deployment scenarios, such as managed SPIRE servers in TZaaS environments or when utilizing Connect as a datasource for the k8s PSAT plugin without requiring local node attestation, allowing for more tailored and permission-restricted deployments. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a disableClusterRoles flag to allow disabling the creation of the ClusterRole and ClusterRoleBinding for node attestation. The implementation is sound and follows Helm best practices. My feedback includes minor suggestions to improve the documentation's precision in README.md and values.yaml to reflect that both resource types are affected by this new flag.
|
@alec-w need ver bump to release tho |
2 participants
Part of https://github.com/cofide/cofide/issues/179
Adds a new value to allow selectively disabling the creation of the cluster roles.
Primary use case is for TZaaS support (when running multiple managed SPIRE servers in a cluster they do not need these ClusterRoles), but this also allows using Connect as the datasource for the k8s psat plugin when attestation of the nodes in the cluster of the SPIRE server isn't required.