Skip to content

Fix loading of prometheus server config#437

Merged
einarmo merged 1 commit intomasterfrom
fix-prom-server-config
May 12, 2025
Merged

Fix loading of prometheus server config#437
einarmo merged 1 commit intomasterfrom
fix-prom-server-config

Conversation

@einarmo
Copy link
Copy Markdown
Contributor

@einarmo einarmo commented May 5, 2025

Loading the _PromServerConfig configuration object failed as it was not annotated as a dataclass, so it had no default conversion from a dict, which caused the YAML deserialization to fail.

Turns out this has never been used.

@einarmo einarmo requested a review from a team as a code owner May 5, 2025 10:50
@nithinb nithinb added the waiting-for-risk-review Waiting for a member of the risk review team to take an action label May 7, 2025
@psalaberria002
Copy link
Copy Markdown
Contributor

broken build, please fix

@einarmo einarmo added waiting-for-team Waiting for the submitter or reviewer of the PR to take an action and removed waiting-for-risk-review Waiting for a member of the risk review team to take an action labels May 7, 2025
@finnag
Copy link
Copy Markdown

finnag commented May 7, 2025

Also please add a more thourough description. What was wrong, how did you fix it, why did that work?

@codecov
Copy link
Copy Markdown

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.35%. Comparing base (0f2aca9) to head (c5cc56d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
+ Coverage   77.32%   77.35%   +0.03%     
==========================================
  Files          42       42              
  Lines        3523     3524       +1     
==========================================
+ Hits         2724     2726       +2     
+ Misses        799      798       -1     
Files with missing lines Coverage Δ
cognite/extractorutils/__init__.py 100.00% <100.00%> (ø)
cognite/extractorutils/configtools/elements.py 80.56% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@einarmo einarmo added waiting-for-risk-review Waiting for a member of the risk review team to take an action and removed waiting-for-team Waiting for the submitter or reviewer of the PR to take an action labels May 9, 2025
@psalaberria002 psalaberria002 added the risk-review-ongoing Risk review is in progress label May 12, 2025
@psalaberria002 psalaberria002 self-assigned this May 12, 2025
Copy link
Copy Markdown
Contributor

@psalaberria002 psalaberria002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@psalaberria002 psalaberria002 added waiting-for-team Waiting for the submitter or reviewer of the PR to take an action and removed waiting-for-risk-review Waiting for a member of the risk review team to take an action labels May 12, 2025
@einarmo einarmo merged commit 376360b into master May 12, 2025
6 checks passed
@einarmo einarmo deleted the fix-prom-server-config branch May 12, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants