Fix loading of prometheus server config#437
Merged
Conversation
nithinb
approved these changes
May 7, 2025
Contributor
|
broken build, please fix |
|
Also please add a more thourough description. What was wrong, how did you fix it, why did that work? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #437 +/- ##
==========================================
+ Coverage 77.32% 77.35% +0.03%
==========================================
Files 42 42
Lines 3523 3524 +1
==========================================
+ Hits 2724 2726 +2
+ Misses 799 798 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading the _PromServerConfig configuration object failed as it was not annotated as a dataclass, so it had no default conversion from a dict, which caused the YAML deserialization to fail.
Turns out this has never been used.