Skip to content

Shorten the messages written to extractor pipeline if its more than 1000 characters#440

Merged
nithinb merged 8 commits intomasterfrom
DOG-5440-db-extractor-fails-to-update-extractor-pipeline-in-case-of-message-longer-than-1000-characters
Jun 23, 2025
Merged

Shorten the messages written to extractor pipeline if its more than 1000 characters#440
nithinb merged 8 commits intomasterfrom
DOG-5440-db-extractor-fails-to-update-extractor-pipeline-in-case-of-message-longer-than-1000-characters

Conversation

@nithinb
Copy link
Copy Markdown
Contributor

@nithinb nithinb commented May 21, 2025

The method self._report_run is being defined here and will be removed from extractors where this is defined to make it easier to maintain.

@nithinb nithinb requested a review from a team as a code owner May 21, 2025 06:00
@codecov
Copy link
Copy Markdown

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.71%. Comparing base (6ec693b) to head (a97f758).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cognite/extractorutils/base.py 84.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   77.46%   77.71%   +0.24%     
==========================================
  Files          42       42              
  Lines        3510     3522      +12     
==========================================
+ Hits         2719     2737      +18     
+ Misses        791      785       -6     
Files with missing lines Coverage Δ
cognite/extractorutils/__init__.py 100.00% <100.00%> (ø)
cognite/extractorutils/base.py 57.14% <84.00%> (+6.05%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@einarmo
Copy link
Copy Markdown
Contributor

einarmo commented May 21, 2025

Okay. The branch name on this PR is absurdly long. I'm not asking you to change it now, but please, keep branch names reasonable.

Nithin Bodanapu and others added 2 commits May 21, 2025 16:35
…lure using exception and using failure message
…actor-pipeline-in-case-of-message-longer-than-1000-characters
@nithinb nithinb requested a review from toondaey June 5, 2025 04:44
@nithinb nithinb requested a review from einarmo June 12, 2025 08:22
Copy link
Copy Markdown
Contributor

@toondaey toondaey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but with some nitpicks.

…tor-utils into DOG-5440-db-extractor-fails-to-update-extractor-pipeline-in-case-of-message-longer-than-1000-characters
@nithinb nithinb force-pushed the DOG-5440-db-extractor-fails-to-update-extractor-pipeline-in-case-of-message-longer-than-1000-characters branch from 754a99a to a97f758 Compare June 16, 2025 08:56
@nithinb nithinb requested a review from toondaey June 18, 2025 05:09
@nithinb nithinb added the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Jun 19, 2025
@rsjr rsjr added the risk-review-ongoing Risk review is in progress label Jun 20, 2025
@rsjr rsjr self-assigned this Jun 20, 2025
Copy link
Copy Markdown
Contributor

@rsjr rsjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

risk review ok

@rsjr rsjr added waiting-for-team Waiting for the submitter or reviewer of the PR to take an action and removed waiting-for-risk-review Waiting for a member of the risk review team to take an action labels Jun 20, 2025
@nithinb nithinb merged commit 5f7b27d into master Jun 23, 2025
6 checks passed
@nithinb nithinb deleted the DOG-5440-db-extractor-fails-to-update-extractor-pipeline-in-case-of-message-longer-than-1000-characters branch June 23, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants