Conversation
`SecretClient` does not accept `None`s as the `credential`. This is a type issue, that `mypy` only _sometimes_ catches. There is no reason the `credentials` should be a class variable, it's only ever used inside the `_init_client` method, so it's fine to move it to a local variable.
nithinb
approved these changes
Jun 11, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #447 +/- ##
=======================================
Coverage 77.47% 77.47%
=======================================
Files 42 42
Lines 3511 3511
=======================================
Hits 2720 2720
Misses 791 791
🚀 New features to boost your workflow:
|
mathialo
added
the
waiting-for-risk-review
larshagencognite
added
risk-review-ongoing
toondaey
added a commit
that referenced
this pull request
Jun 11, 2025
`SecretClient` does not accept `None`s as the `credential`. This is a type issue, that `mypy` only _sometimes_ catches. There is no reason the `credentials` should be a class variable, it's only ever used inside the `_init_client` method, so it's fine to move it to a local variable.
cognite-bulldozer bot
added a commit
that referenced
this pull request
Jun 26, 2025
* Update connection config schema * feat: cast credentials * fix: use external id * feat: update method * test: test casting * chore: change variable to match * test: comprehensive test of full config-schema * Fix type issue in `KeyValutLoader` (#447) `SecretClient` does not accept `None`s as the `credential`. This is a type issue, that `mypy` only _sometimes_ catches. There is no reason the `credentials` should be a class variable, it's only ever used inside the `_init_client` method, so it's fine to move it to a local variable. * feat: scopes config list * feat: expose connection parameters * fix: update cognite sdk version --------- Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SecretClientdoes not acceptNones as thecredential. This is atype issue, that
mypyonly sometimes catches.There is no reason the
credentialsshould be a class variable, it'sonly ever used inside the
_init_clientmethod, so it's fine to move itto a local variable.