Skip to content

Fix type issue in KeyValutLoader #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathialo merged 1 commit into from
Jun 11, 2025
Merged

Fix type issue in KeyValutLoader #447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions cognite/extractorutils/configtools/loaders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

import dacite
import yaml
from azure.core.credentials import TokenCredential
from azure.core.exceptions import HttpResponseError, ResourceNotFoundError, ServiceRequestError
from azure.identity import ClientSecretCredential, DefaultAzureCredential
from azure.keyvault.secrets import SecretClient
Expand Down Expand Up @@ -64,7 +65,6 @@ class KeyVaultLoader:
def __init__(self, config: dict | None):
self.config = config

self.credentials: DefaultAzureCredential | ClientSecretCredential | None = None
self.client: SecretClient | None = None

def _init_client(self) -> None:
Expand All @@ -88,9 +88,10 @@ def _init_client(self) -> None:

vault_url = f"https://{keyvault_name}.vault.azure.net"

credentials: TokenCredential
if self.config["authentication-method"] == KeyVaultAuthenticationMethod.DEFAULT.value:
_logger.info("Using Azure DefaultCredentials to access KeyVault")
self.credentials = DefaultAzureCredential()
credentials = DefaultAzureCredential()

elif self.config["authentication-method"] == KeyVaultAuthenticationMethod.CLIENTSECRET.value:
auth_parameters = ("client-id", "tenant-id", "secret")
Expand All @@ -107,7 +108,7 @@ def _init_client(self) -> None:
client_id = os.path.expandvars(self.config["client-id"])
secret = os.path.expandvars(self.config["secret"])

self.credentials = ClientSecretCredential(
credentials = ClientSecretCredential(
tenant_id=tenant_id,
client_id=client_id,
client_secret=secret,
Expand All @@ -121,7 +122,7 @@ def _init_client(self) -> None:
"Invalid KeyVault authentication method. Possible values : default or client-secret"
)

self.client = SecretClient(vault_url=vault_url, credential=self.credentials)
self.client = SecretClient(vault_url=vault_url, credential=credentials)

def __call__(self, _: yaml.SafeLoader, node: yaml.Node) -> str:
self._init_client()
Expand Down
Loading