-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Honda: CANFD long control #2569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
That's not necessary, each Panda only knows about what it's hooked up to.
Will have to look and see what's broken. |
This could be connected to #2632. Not saying it is for sure, but Panda is dealing with a disruption that can back up queues and affect other buses as well, so I wouldn't spend a bunch more time on it until that's been resolved. |
|
Reopening as this is testing well with the cruise fault workaround linked in the description. |
|
In separate AEB testing, found that radar hud was previously blocked by safety. Changed this PR to allow it through to properly displays that CMBS is off on the instrument cluster. No driving impact noticed in testdrive. |
Adding long control for Honda CANFD models.
Based on PR2162, rebaseling to current opendbc codebase, with addition of safety code.
This PR had been in draft for months, due to the cruise faults set at a subsequent drive after long control was enabled.
I suspect the car is detecting the radar tester and throwing a fault at shutdown. I matched every control bit from a factory ACC log upon shutdown, except for the radar tester, and the next drive still faulted. All Honda Bosch models retain prior faults for the first few seconds of a subsequent drive, so I have not found any other way to stop next-drive faulting beyond PR3029.
There are sometimes split-second error messages appearing on the dashboard before clearing, but long control is gated behind alphalong on dev-only, so release drivers will not see this.
Recent drive from a canfd loaner: ad9840558640c31d/00000195--03d04b0d1c