Skip to content

Conversation

@mvl-boston
Copy link
Contributor

@mvl-boston mvl-boston commented Jul 26, 2025

Adding long control for Honda CANFD models.

Based on PR2162, rebaseling to current opendbc codebase, with addition of safety code.

This PR had been in draft for months, due to the cruise faults set at a subsequent drive after long control was enabled.

I suspect the car is detecting the radar tester and throwing a fault at shutdown. I matched every control bit from a factory ACC log upon shutdown, except for the radar tester, and the next drive still faulted. All Honda Bosch models retain prior faults for the first few seconds of a subsequent drive, so I have not found any other way to stop next-drive faulting beyond PR3029.

There are sometimes split-second error messages appearing on the dashboard before clearing, but long control is gated behind alphalong on dev-only, so release drivers will not see this.

Recent drive from a canfd loaner: ad9840558640c31d/00000195--03d04b0d1c

@jyoung8607
Copy link
Collaborator

jyoung8607 commented Aug 7, 2025

@jyoung8607
Copy link
Collaborator

  1. Does comma3+red panda usage require bus 4 as written?

That's not necessary, each Panda only knows about what it's hooked up to.

  1. This makes startup faults temporary as car does this if engine is restarted too soon after shutdown. Is there another way to buffer flush at shutdown to prevent?

Will have to look and see what's broken.

@jyoung8607 jyoung8607 marked this pull request as draft August 7, 2025 09:44
@jyoung8607 jyoung8607 moved this from In progress to In review in Honda: The Power of Dreams Aug 7, 2025
@jyoung8607 jyoung8607 moved this from In review to Backlog in Honda: The Power of Dreams Aug 7, 2025
@jyoung8607
Copy link
Collaborator

  • Why does it fault on quick restarts?

This could be connected to #2632. Not saying it is for sure, but Panda is dealing with a disruption that can back up queues and affect other buses as well, so I wouldn't spend a bunch more time on it until that's been resolved.

@mvl-boston
Copy link
Contributor Author

Reopening as this is testing well with the cruise fault workaround linked in the description.

@mvl-boston mvl-boston marked this pull request as ready for review January 9, 2026 01:26
@github-actions github-actions bot added DBC signals can related to CAN tools, aka opendbc/can/ labels Jan 9, 2026
@mvl-boston mvl-boston marked this pull request as draft January 9, 2026 06:21
@github-actions github-actions bot removed can related to CAN tools, aka opendbc/can/ DBC signals labels Jan 9, 2026
@mvl-boston mvl-boston marked this pull request as ready for review January 9, 2026 06:36
@mvl-boston
Copy link
Contributor Author

In separate AEB testing, found that radar hud was previously blocked by safety. Changed this PR to allow it through to properly displays that CMBS is off on the instrument cluster. No driving impact noticed in testdrive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

car safety vehicle-specific safety code car related to opendbc/car/ honda

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants