Skip to content

Honda - support RDX 3G variants with brake booster (alt_brake) #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mvl-boston wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Honda - support RDX 3G variants with brake booster (alt_brake) #2973

mvl-boston wants to merge 4 commits into from
+1 −1

Conversation

@mvl-boston
Copy link
Contributor

@mvl-boston mvl-boston commented Dec 20, 2025 •
edited
Loading

Some 3rd gen RDX models have a brake booster and thus need the alt-brake flag autodetected.

alt-brake causes the correct brakepressed carstate to be set.

d9ac1a7b6755fff9/0000001f--8e7db88e99

@github-actions github-actions bot added car related to opendbc/car/ honda labels Dec 20, 2025
BaharathBathula
BaharathBathula reviewed Dec 20, 2025
View reviewed changes
Copy link

@BaharathBathula BaharathBathula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution. You might consider separating this logic into a smaller
helper function to improve readability and testability.

@mvl-boston
Copy link
Contributor Author

mvl-boston commented Dec 21, 2025 •
edited
Loading

Nice contribution. You might consider separating this logic into a smaller helper function to improve readability and testability.

Not sure what you are recommending? Long term #2919 is cleaner, but if comma prefers less of a change than this PR will solve the short term issue.

@mvl-boston mvl-boston marked this pull request as ready for review December 24, 2025 22:23
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

Testing 154 segments for: HONDA_ACCORD, HONDA_CIVIC_BOSCH, HONDA_CIVIC_2022, HONDA_CRV_5G, HONDA_CRV_HYBRID, HONDA_HRV_3G, HONDA_INSIGHT, HONDA_E, HONDA_PILOT_4G, HONDA_CRV, HONDA_FIT, HONDA_FREED, HONDA_HRV, HONDA_ODYSSEY, HONDA_PILOT, HONDA_RIDGELINE, HONDA_CIVIC

Results: 154 passed, 0 with diffs, 0 errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BaharathBathula BaharathBathula BaharathBathula left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

car related to opendbc/car/ honda

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mvl-boston @BaharathBathula @elkoled