Skip to content

Honda - support RDX 3G variants with brake booster (alt_brake) #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sshane merged 4 commits into from
Jan 24, 2026
+1 −1
Merged

Honda - support RDX 3G variants with brake booster (alt_brake) #2973

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e55ab59
Add ACURA_RDX_3G to alternate brake message check
mvl-boston Dec 20, 2025
ca3f95f
Merge branch 'master' into rdx-brakebooster
mvl-boston Dec 23, 2025
2165aed
Merge branch 'master' into rdx-brakebooster
elkoled Jan 20, 2026
b648bc2
Merge branch 'master' into rdx-brakebooster
elkoled Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion opendbc/car/honda/interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def _get_params(ret: structs.CarParams, candidate, fingerprint, car_fw, alpha_lo
CarInterfaceBase.configure_torque_tune(candidate, ret.lateralTuning)

# These cars use alternate user brake msg (0x1BE)
if 0x1BE in fingerprint[CAN.pt] and candidate in (CAR.HONDA_ACCORD, CAR.HONDA_HRV_3G, *HONDA_BOSCH_CANFD):
if 0x1BE in fingerprint[CAN.pt] and candidate in (CAR.HONDA_ACCORD, CAR.HONDA_HRV_3G, CAR.ACURA_RDX_3G, *HONDA_BOSCH_CANFD):
Copy link
Contributor

@sshane sshane Jan 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder why we have this set if we do live detection, can any car have 0x1BE and we don't want to use it? Removing would simplify things

Copy link
Contributor Author

@mvl-boston mvl-boston Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. PR2919 does generic live detection. I had wanted to learn huggingface scripting to do a global regression test before opening gates broadly. Hadn't had a chance to try yet which is why 2919 is in draft.

ret.flags |= HondaFlags.BOSCH_ALT_BRAKE.value

if ret.flags & HondaFlags.BOSCH_ALT_BRAKE:
Expand Down