ui: split debug logic into DebugGuiApplication #36632
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
raylib UI PreviewAll Screenshots
|
deanlee
force-pushed
the
ui-app-debug
branch
2 times, most recently
from
bd019c5 to
60ae3dc
Compare
deanlee
force-pushed
the
ui-app-debug
branch
4 times, most recently
from
5991055 to
e8af0e8
Compare
deanlee
force-pushed
the
ui-app-debug
branch
from
e8af0e8 to
c5dedab
Compare
sshane
reviewed
Nov 27, 2025
Comment on lines
+482
to
+491
| # Lazy factory to create the app | ||
| def _create_gui_app(width=None, height=None): | ||
| is_release = Params().get_bool("IsReleaseBranch") | ||
| if not is_release: | ||
| from openpilot.system.ui.lib.debug_application import DebugGuiApplication | ||
| return DebugGuiApplication(width, height) | ||
|
|
||
| return GuiApplication(width, height) | ||
|
|
||
| gui_app = _create_gui_app() |
Contributor
There was a problem hiding this comment.
I'm not sure I like the two paths this way. It should definitely at least be behind a flag, not release param
Contributor
|
We can split out debugging code for clarity, but let's not over optimize too much (like two mouse initializers) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts all debug-only functionality into a new
DebugGuiApplicationsubclass and keepsGuiApplicationfocused on production behavior.Key changes:
DebugGuiApplicationsubclass.GuiApplicationminimal and focused on release behavior (scale 1.0, no debug overlays).application.pythat instantiatesDebugGuiApplicationfor debug andGuiApplicationotherwise.Benefits: