Skip to content

Improve pytest collection time to <1s issue #32611 #36821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pipinstalled wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve pytest collection time to <1s issue #32611 #36821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@
import os
import pytest

from openpilot.common.prefix import OpenpilotPrefix
from openpilot.system.manager import manager
from openpilot.system.hardware import TICI, HARDWARE

# TODO: pytest-cpp doesn't support FAIL, and we need to create test translations in sessionstart
# pending https://github.com/pytest-dev/pytest-cpp/pull/147
collect_ignore = [
Expand Down Expand Up @@ -47,6 +43,7 @@ def clean_env():

@pytest.fixture(scope="function", autouse=True)
def openpilot_function_fixture(request):
from openpilot.common.prefix import OpenpilotPrefix
with clean_env():
# setup a clean environment for each test
with OpenpilotPrefix(shared_download_cache=request.node.get_closest_marker("shared_download_cache") is not None) as prefix:
Expand All @@ -58,6 +55,7 @@ def openpilot_function_fixture(request):
assert "OPENPILOT_PREFIX" in os.environ and prefix == os.environ["OPENPILOT_PREFIX"]

# cleanup any started processes
from openpilot.system.manager import manager
manager.manager_cleanup()

# some processes disable gc for performance, re-enable here
Expand All @@ -78,13 +76,19 @@ def tici_setup_fixture(request, openpilot_function_fixture):
"""Ensure a consistent state for tests on-device. Needs the openpilot function fixture to run first."""
if 'skip_tici_setup' in request.keywords:
return
from openpilot.system.hardware import HARDWARE
HARDWARE.initialize_hardware()
HARDWARE.set_power_save(False)
os.system("pkill -9 -f athena")


@pytest.hookimpl(tryfirst=True)
def pytest_collection_modifyitems(config, items):
# Only import TICI if there are tici tests to process
has_tici_tests = any("tici" in item.keywords for item in items)
TICI = None
if has_tici_tests:
from openpilot.system.hardware import TICI
skipper = pytest.mark.skip(reason="Skipping tici test on PC")
for item in items:
if "tici" in item.keywords:
Expand Down