Skip to content

fix(clip): no empty frames #37054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
greatgitsby wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(clip): no empty frames #37054

greatgitsby wants to merge 2 commits into from
+49 −30

Conversation

@greatgitsby
Copy link
Contributor

@greatgitsby greatgitsby commented Feb 1, 2026 •
edited
Loading

dependent on #37053

  • start recording after the first road frame loads. this is for several reasons:
    • UI needs to "warmup" (vipc road frame isn't immediately available, results in black frames at begin)
    • frame calibration matrix needs at least one frame to compute, otherwise you see camera shift in the video
    • UI state needs one frame after first road frame to settle (engaged status, dmon, etc.)
    • see before/after to see this behavior
tools/clip/run.py --demo --start 150 --end 170 --big

before

output.mp4

after

output.mp4

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026 •
edited
Loading

mici raylib UI Preview

✅ Videos are identical! View Diff Report

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026 •
edited
Loading

raylib UI Preview

All Screenshots

@greatgitsby greatgitsby force-pushed the clip/remove-black-frames branch from 8864753 to 9d4c1fb Compare February 6, 2026 14:51
@greatgitsby greatgitsby marked this pull request as ready for review February 6, 2026 15:05
@greatgitsby greatgitsby marked this pull request as draft February 6, 2026 15:09
@greatgitsby greatgitsby force-pushed the clip/remove-black-frames branch 2 times, most recently from 7504984 to ed9b3f1 Compare February 7, 2026 16:16
@greatgitsby greatgitsby marked this pull request as ready for review February 7, 2026 16:26
@greatgitsby greatgitsby marked this pull request as draft February 7, 2026 16:26
@greatgitsby greatgitsby marked this pull request as ready for review February 7, 2026 16:26
@greatgitsby greatgitsby force-pushed the clip/remove-black-frames branch from a335f38 to d567e85 Compare February 8, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@greatgitsby