Skip to content

CRAFT-2061-Correct Combobox msgs #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
valoriecarli merged 2 commits into from
Jan 20, 2026
Merged

CRAFT-2061-Correct Combobox msgs #925

valoriecarli merged 2 commits into from
Jan 20, 2026

Conversation

@valoriecarli
Copy link
Collaborator

@valoriecarli valoriecarli commented Jan 20, 2026

Somewhere in the sea of rebasing and combobox & intl refactoring, we lost the combobox.i18n.ts file.
This restores in with the updated messages provided in #630

A ticket is being created now to give Tx the heads up.

@valoriecarli valoriecarli self-assigned this Jan 20, 2026
@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: b24f16d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 20, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nimbus-documentation Ready Ready Preview, Comment Jan 20, 2026 4:39pm
nimbus-storybook Ready Ready Preview, Comment Jan 20, 2026 4:39pm

Request Review

@valoriecarli valoriecarli requested review from a team, ByronDWall, ddouglasz, jaikamat, misama-ct, stephsprinkle and tylermorrisford and removed request for a team January 20, 2026 16:29
@valoriecarli valoriecarli changed the title CRAFT-2061-Correct combobox msgs CRAFT-2061-Correct Combobox msgs Jan 20, 2026
tylermorrisford
tylermorrisford approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@tylermorrisford tylermorrisford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier threw a fit but I approve... chill out prettier!

@valoriecarli valoriecarli merged commit 7294db4 into main Jan 20, 2026
8 checks passed
@valoriecarli valoriecarli deleted the CRAFT-2061-correct-combobox-msgs branch January 20, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaikamat jaikamat jaikamat approved these changes

@ddouglasz ddouglasz ddouglasz approved these changes

@tylermorrisford tylermorrisford tylermorrisford approved these changes

@stephsprinkle stephsprinkle Awaiting requested review from stephsprinkle stephsprinkle was automatically assigned from commercetools/craft-team-fe-tag-all

@ByronDWall ByronDWall Awaiting requested review from ByronDWall ByronDWall was automatically assigned from commercetools/craft-team-fe-tag-all

@misama-ct misama-ct Awaiting requested review from misama-ct misama-ct was automatically assigned from commercetools/craft-team-fe-tag-all

Assignees

@valoriecarli valoriecarli

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@valoriecarli @jaikamat @ddouglasz @tylermorrisford