Skip to content

CRAFT-2061-Correct Combobox msgs #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valoriecarli merged 2 commits into from
Jan 20, 2026
Merged

CRAFT-2061-Correct Combobox msgs #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95af770
chore(intl): correct combobox msgs
valoriecarli Jan 20, 2026
b24f16d
fix(lint): make the linter happy
valoriecarli Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/i18n/data/core.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,22 @@
"developer_comment": "aria-label for previous year navigation button",
"string": "Previous year"
},
"Nimbus.ComboBox.clearSelection": {
"developer_comment": "aria-label for clear selection button in ComboBox",
"string": "Clear selection"
},
"Nimbus.ComboBox.options": {
"developer_comment": "aria-label for combobox menu options",
"string": "Options menu"
},
"Nimbus.ComboBox.selectedValues": {
"developer_comment": "aria-label for selected values tag group",
"string": "Selected values"
},
"Nimbus.ComboBox.toggleOptions": {
"developer_comment": "aria-label for toggle button to open/close options",
"string": "Toggle options"
},
"Nimbus.DataTable.comfortable": {
"developer_comment": "title for the comfortable togglebutton in the data table manager layout",
"string": "Comfortable"
Expand Down
24 changes: 24 additions & 0 deletions packages/nimbus/src/components/combobox/combobox.i18n.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import { defineMessages } from "react-intl";

export const messages = defineMessages({
selectedValues: {
id: "Nimbus.ComboBox.selectedValues",
description: "aria-label for selected values tag group",
defaultMessage: "Selected values",
},
toggleOptions: {
id: "Nimbus.ComboBox.toggleOptions",
description: "aria-label for toggle button to open/close options",
defaultMessage: "Toggle options",
},
clearSelection: {
id: "Nimbus.ComboBox.clearSelection",
description: "aria-label for clear selection button in ComboBox",
defaultMessage: "Clear selection",
},
options: {
id: "Nimbus.ComboBox.options",
description: "aria-label for combobox menu options",
defaultMessage: "Options menu",
},
});