Fix Double location off messages in explore/map #6598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
This PR fixes an issue in Explore → Map where the turn on location services dialog was shown multiple times even after the user enabled location services from system settings.
Fixes #6597
What changes did you make and why?
Root cause
ExploreFragmentwas registering aViewPager.OnPageChangeListenertwice:onCreateView()onCreateOptionsMenu()onCreateOptionsMenu()can be called multiple times during the fragment lifecycle so this resulted in multiple listeners being added over time.Each listener calls:
mapRootFragment?.requestLocationIfNeeded()Tests performed (required)
after I ran lint and verified the project builds successfully using the BetaDebug build variant.
Tested {build variant betaDebug} on {Galaxy s23 } with android 16.
Screenshots (for UI changes only)
before :
Screen_Recording_20260101_152652_Commons.mp4
after:
Screen_Recording_20260102_211854_Commons.mp4