Skip to content

Fix Double location off messages in explore/map #6598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RitikaPahwa4444 merged 2 commits into from
Jan 18, 2026
+3 −13
Merged

Fix Double location off messages in explore/map #6598

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbc570e
Fix Double location off messages in explore/map
Salehcodes Jan 2, 2026
858959f
Merge branch 'main' into fix-double-location-permission-messages-in-e…
RitikaPahwa4444 Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions app/src/main/java/fr/free/nrw/commons/explore/ExploreFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ class ExploreFragment : CommonsDaggerSupportFragment() {
override fun onPageScrollStateChanged(state: Int) = Unit
override fun onPageSelected(position: Int) {
binding!!.viewPager.canScroll = position != 2
// based on which tab we are now recreate the options menu
activity?.invalidateOptionsMenu()

if (position == 2) {
mapRootFragment?.requestLocationIfNeeded()
}
Expand Down Expand Up @@ -178,19 +181,6 @@ class ExploreFragment : CommonsDaggerSupportFragment() {
if (binding!!.viewPager.currentItem == 2) {
others.setVisible(true)
}

// if on Map tab, show all menu options, else only show search
binding!!.viewPager.addOnPageChangeListener(object : OnPageChangeListener {
override fun onPageScrolled(position: Int, positionOffset: Float, positionOffsetPixels: Int) = Unit
override fun onPageScrollStateChanged(state: Int) = Unit
override fun onPageSelected(position: Int) {
binding!!.viewPager.canScroll = position != 2
others.setVisible(position == 2)
if (position == 2) {
mapRootFragment?.requestLocationIfNeeded()
}
}
})
} else {
inflater.inflate(R.menu.menu_search, menu)
}
Expand Down