Add Ubuntu 24.04 arm runners to ci #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
==========================================
+ Coverage 71.15% 71.17% +0.01%
==========================================
Files 9 9
Lines 3550 3552 +2
==========================================
+ Hits 2526 2528 +2
Misses 1024 1024
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mcbarton
force-pushed
the
Add-ubuntu-24.04-arm-runners
branch
from
dfefb04 to
fcbaeff
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
4 tasks
vgvassilev
reviewed
Jan 19, 2025
|
clang-tidy review says "All clean, LGTM! 👍" |
mcbarton
force-pushed
the
Add-ubuntu-24.04-arm-runners
branch
from
e292564 to
ca8bfb3
Compare
mcbarton
force-pushed
the
Add-ubuntu-24.04-arm-runners
branch
from
ca8bfb3 to
b1dcceb
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
mcbarton
force-pushed
the
Add-ubuntu-24.04-arm-runners
branch
from
b1dcceb to
f2b2789
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
mcbarton
force-pushed
the
Add-ubuntu-24.04-arm-runners
branch
from
0bddb91 to
bb6f6ad
Compare
vgvassilev
reviewed
Jan 21, 2025
Update lib/Interpreter/CppInterOp.cpp
mcbarton
force-pushed
the
Add-ubuntu-24.04-arm-runners
branch
from
b13f739 to
1b57229
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
I wanted to do this PR when we added the new Ubuntu 22.04 arm runners to the ci, but we didn't have the cache space. Also CppInterOp doesn't current support Ubuntu 24.04 x86 due to an unfixed warning, so its not guaranteed to pass.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist