Skip to content

Conversation

@mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Aug 6, 2025

Description

Please include a summary of changes, motivation and context for this PR.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@mcbarton mcbarton requested a review from vgvassilev August 6, 2025 14:10
@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.68%. Comparing base (c849ba4) to head (9bab6cd).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #694      +/-   ##
==========================================
- Coverage   79.68%   79.68%   -0.01%     
==========================================
  Files           9        9              
  Lines        3943     3942       -1     
==========================================
- Hits         3142     3141       -1     
  Misses        801      801              
Files with missing lines Coverage Δ
lib/CppInterOp/Compatibility.h 92.50% <ø> (-0.07%) ⬇️
Files with missing lines Coverage Δ
lib/CppInterOp/Compatibility.h 92.50% <ø> (-0.07%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@mcbarton mcbarton force-pushed the Remove-unused-variables branch from 9a4bf0f to 9bab6cd Compare August 6, 2025 14:27
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton
Copy link
Collaborator Author

mcbarton commented Aug 7, 2025

This PR is ready for review

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcbarton mcbarton merged commit 41f26a3 into compiler-research:main Aug 7, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants