Skip to content

Remove unused variables #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcbarton merged 1 commit into from
Aug 7, 2025
Merged

Remove unused variables #694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/CppInterOp/Compatibility.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,6 @@ inline void codeComplete(std::vector<std::string>& Results,
}

std::vector<std::string> results;
std::vector<std::string> Comps;
clang::CompilerInstance* MainCI = (*Interp)->getCompilerInstance();
auto CC = clang::ReplCodeCompleter();
CC.codeComplete(MainCI, code, complete_line, complete_column,
Expand Down
13 changes: 7 additions & 6 deletions unittests/CppInterOp/FunctionReflectionTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ TEST(FunctionReflectionTest, GetFunctionRequiredArgs) {
}

TEST(FunctionReflectionTest, GetFunctionArgType) {
std::vector<Decl*> Decls, SubDecls;
std::vector<Decl*> Decls;
std::string code = R"(
void f1(int i, double d, long l, char ch) {}
void f2(const int i, double d[], long *l, char ch[4]) {}
Expand All @@ -582,7 +582,7 @@ TEST(FunctionReflectionTest, GetFunctionArgType) {
}

TEST(FunctionReflectionTest, GetFunctionSignature) {
std::vector<Decl*> Decls, SubDecls;
std::vector<Decl*> Decls;
std::string code = R"(
class C {
void f(int i, double d, long l = 0, char ch = 'a') {}
Expand Down Expand Up @@ -626,7 +626,8 @@ TEST(FunctionReflectionTest, GetFunctionSignature) {
}

TEST(FunctionReflectionTest, IsTemplatedFunction) {
std::vector<Decl*> Decls, SubDeclsC1, SubDeclsC2;
std::vector<Decl*> Decls;
std::vector<Decl*> SubDeclsC1;
std::string code = R"(
void f1(int a) {}

Expand Down Expand Up @@ -1448,7 +1449,7 @@ TEST(FunctionReflectionTest, GetFunctionAddress) {
#ifdef _WIN32
GTEST_SKIP() << "Disabled on Windows. Needs fixing.";
#endif
std::vector<Decl*> Decls, SubDecls;
std::vector<Decl*> Decls;
std::string code = "int f1(int i) { return i * i; }";
std::vector<const char*> interpreter_args = {"-include", "new"};

Expand Down Expand Up @@ -2132,7 +2133,7 @@ TEST(FunctionReflectionTest, IsConstMethod) {
}

TEST(FunctionReflectionTest, GetFunctionArgName) {
std::vector<Decl*> Decls, SubDecls;
std::vector<Decl*> Decls;
std::string code = R"(
void f1(int i, double d, long l, char ch) {}
void f2(const int i, double d[], long *l, char ch[4]) {}
Expand Down Expand Up @@ -2172,7 +2173,7 @@ TEST(FunctionReflectionTest, GetFunctionArgName) {
}

TEST(FunctionReflectionTest, GetFunctionArgDefault) {
std::vector<Decl*> Decls, SubDecls;
std::vector<Decl*> Decls;
std::string code = R"(
void f1(int i, double d = 4.0, const char *s = "default", char ch = 'c') {}
void f2(float i = 0.0, double d = 3.123, long m = 34126) {}
Expand Down
1 change: 0 additions & 1 deletion unittests/CppInterOp/ScopeReflectionTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,6 @@ TEST(ScopeReflectionTest, IsBuiltin) {
EXPECT_TRUE(Cpp::IsBuiltin(C.getComplexType(C.Float128Ty).getAsOpaquePtr()));

// std::complex
std::vector<Decl*> Decls;
Interp->declare("#include <complex>");
Sema &S = Interp->getCI()->getSema();
auto lookup = S.getStdNamespace()->lookup(&C.Idents.get("complex"));
Expand Down
2 changes: 1 addition & 1 deletion unittests/CppInterOp/VariableReflectionTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ TEST(VariableReflectionTest, IsConstVariable) {
}

TEST(VariableReflectionTest, DISABLED_GetArrayDimensions) {
std::vector<Decl *> Decls, SubDecls;
std::vector<Decl *> Decls;
std::string code = R"(
int a;
int b[1];
Expand Down
Loading