Only run Valgrind on ci jobs we choose ci #760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcbarton
force-pushed
the
Run-Valgrind-only-for-latest-llvm
branch
from
72644a6 to
eb2fcde
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #760 +/- ##
=======================================
Coverage 79.04% 79.04%
=======================================
Files 9 9
Lines 3880 3880
=======================================
Hits 3067 3067
Misses 813 813 🚀 New features to boost your workflow:
|
Vipul-Cariappa
approved these changes
Nov 28, 2025
Collaborator
Vipul-Cariappa
left a comment
Vipul-Cariappa
left a comment
There was a problem hiding this comment.
LGTM!
Hi @mcbarton, in future, make sure that the oop-jit is running with Valgrind, even if it is not the latest LLVM. I believe with the next LLVM release, we can drop the LLVM patch we have. And things will become easy. You are the CI guy, and I may forgot about this 😄.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we will now only run the tests under Valgrind for ci jobs we choose. In this PR I have set it to only run for the latest llvm for Ubuntu arm and Ubuntu x86.