Skip to content

Only run Valgrind on ci jobs we choose ci #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vipul-Cariappa merged 3 commits into from
Nov 28, 2025
Merged

Only run Valgrind on ci jobs we choose ci #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb2fcde
Only run tests under Valgrind for specific ci jobs
mcbarton Nov 27, 2025
65e8f15
Fix conditional check for Valgrind in action.yml
mcbarton Nov 27, 2025
0c1ba2e
Fix syntax for accessing matrix variable in action.yml
mcbarton Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/Build_and_Test_CppInterOp/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ runs:
else
cmake --build . --target check-cppinterop --parallel ${{ env.ncpus }}
os="${{ matrix.os }}"
if [[ "${os}" != "macos"* ]]; then
if [[ "${os}" != "macos"* && "${{ matrix.Valgrind }}" == "On" ]]; then
CLANG_VERSION="${{ matrix.clang-runtime }}"
if [[ "$CLANG_VERSION" == "20" && "${{ matrix.cling }}" == "Off" ]]; then
SUPPRESSION_FILE="../etc/clang${CLANG_VERSION}-valgrind.supp"
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/Build_and_Test_cppyy/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ runs:

set -o pipefail
os="${{ matrix.os }}"
if [[ "${os}" != "macos"* ]]; then
if [[ "${os}" != "macos"* && "${{ matrix.Valgrind }}" == "On" ]]; then
echo "Running valgrind on passing tests"
CLANG_VERSION="${{ matrix.clang-runtime }}"

Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ jobs:
cppyy: Off
llvm_enable_projects: "clang"
llvm_targets_to_build: "host;NVPTX"
Valgrind: On
- name: ubu24-arm-gcc12-clang-repl-19-cppyy
os: ubuntu-24.04-arm
compiler: gcc-12
Expand Down Expand Up @@ -67,6 +68,7 @@ jobs:
llvm_targets_to_build: "host;NVPTX"
coverage: true
oop-jit: On
Valgrind: On
- name: ubu24-x86-gcc12-clang-repl-20
os: ubuntu-24.04
compiler: gcc-12
Expand Down Expand Up @@ -311,3 +313,4 @@ jobs:
uses: mxschmitt/action-tmate@v3
# When debugging increase to a suitable value!
timeout-minutes: 30

Loading