- 
                Notifications
    
You must be signed in to change notification settings  - Fork 36
 
Removed redundant installation of tagfiles in lite #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          20       20           
  Lines         950      950           
  Branches       87       87           
=======================================
  Hits          777      777           
  Misses        173      173           🚀 New features to boost your workflow:
  | 
    
| 
           Hey @kr-2003, Would need some help ! Could you please try all the inline documentation use cases mentioned here (https://xeus-cling.readthedocs.io/en/latest/inline_help.html) There are 3 sections I suppose. These are xeus-cling docs, we need to see if everything works for lite. If yes, we need to update xeus-cpp's documentation to also add the same.  | 
    
          
 I have tried for   
To enable documentation for third-party libs, we need to follow these steps.  | 
    
          
 Ohh the xtensor based files are also being preloaded and not being picked up from the prefix correct ?  | 
    
          
 Yes  | 
    
| 
           Hey @kr-2003 , thanks for the work here but as discussed I think we would have to keep the tagfiles in the prefix for jupyterlite-xeus to pick them up !  | 
    
| 
           I’d like these discussions to happen under the relevant issues and not in private.  | 
    
          
 I agree that xeus-cpp should not include third-party tag files. Each third-party package should be responsible for including their tag files, which are then picked up by xeus-cpp.  | 
    



Fixes #267

