Skip to content

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Jun 6, 2025

Description

Please include a summary of changes, motivation and context for this PR.

If you look at Emscripten xeus-cpp recipe in Emscripten forge here https://github.com/emscripten-forge/recipes/blob/b34db3abcffbec2b24b97d4fd8def6c4d31888e4/recipes/recipes_emscripten/xeus-cpp/recipe.yaml#L22C19-L22C24 , it has a minimum version of xeus-lite of 3.2.1. This PR makes it is so that cmake also has this minimum required version

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (7ecb686) to head (7a9fc12).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #339   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          20       20           
  Lines         950      950           
  Branches       87       87           
=======================================
  Hits          777      777           
  Misses        173      173           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcbarton mcbarton force-pushed the Set-minimum-xeus-lite-cmake branch from 964abe2 to 76d0934 Compare June 6, 2025 16:13
@mcbarton mcbarton force-pushed the Set-minimum-xeus-lite-cmake branch from 12471f4 to 7a9fc12 Compare June 6, 2025 16:28
@SylvainCorlay SylvainCorlay merged commit 4a49cc4 into compiler-research:main Jun 6, 2025
15 checks passed
@mcbarton mcbarton deleted the Set-minimum-xeus-lite-cmake branch June 27, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants