Skip to content

Set minimum required xeus-lite version to 3.2.1 #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025
Merged

Set minimum required xeus-lite version to 3.2.1 #339

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db2d3d1
Set minimum required xeus-lite version to 3.2.1
mcbarton Jun 6, 2025
7a9fc12
Apply PR suggestion
mcbarton Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ endif()
set(xeus_REQUIRED_VERSION 5.0.0)
set(xeus_zmq_REQUIRED_VERSION 3.0.0)
set(CppInterOp_REQUIRED_VERSION 1.7.0)
set(xeus_lite_REQUIRED_VERSION 3.2.1)

if (NOT TARGET xeus AND NOT TARGET xeus-static)
find_package(xeus ${xeus_REQUIRED_VERSION} REQUIRED)
Expand Down Expand Up @@ -439,7 +440,7 @@ if(EMSCRIPTEN)
message(FATAL_ERROR "Failed to run 'embuilder build sdl2'")
endif()
include(WasmBuildOptions)
find_package(xeus-lite REQUIRED)
find_package(xeus-lite ${xeus_lite_REQUIRED_VERSION} REQUIRED)
add_executable(xcpp src/main_emscripten_kernel.cpp )
target_link_libraries(xcpp PRIVATE xeus-lite)
xeus_cpp_set_kernel_options(xcpp)
Expand Down