-
Notifications
You must be signed in to change notification settings - Fork 67
Refactor: classes for format checking #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
7278451 to
4f66239
Compare
List allowed types in verbose error output
4f66239 to
02aba2e
Compare
02aba2e to
bd2f594
Compare
bd2f594 to
4684800
Compare
lalver1
approved these changes
Dec 20, 2024
Member
lalver1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @thekaveman. I went over the refactor to use classes and was able to follow the changes. Then I ran the script to test a merge commit with and without the --strict flag and saw the new behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conventional_pre_commit.formatmodule to use classes instead of the top-level functionsCommitorConventionalCommitclassconventional_pre_commit.format.is_conventional()still exists with the same signatureFinally, this PR introduces the long requested feature to skip merge commits, e.g.
Merge branch 'dev' into 'main'. The--strictflag maintains existing behavior of disallowing merge commits.ht @zlodes #103
Updates the documentation to close #104