-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Add recipe for woff2 #30722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add recipe for woff2 #30722
Conversation
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/woff2/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16748522769. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I agree to be added as maintainer of this package |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
@conda-forge-admin, please ping team @conda-forge/help-c-cpp |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/staged-recipes and so here I am doing that. |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
- bin/woff2_compress | ||
- bin/woff2_decompress | ||
- bin/woff2_info | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some smoke tests for the binaries?
For example:
- script:
- woff2_compress --help
- woff2_decompress --help ...
If you want to go really fancy, you could add a small test file and test the progarms with that file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opted for the fancier approach, as there's no --help
command or similar which we could use here. Added a small script which tests converting ttf->woff2 and vice versa (inspired by woff2 homebrew formula)
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).