-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Add recipe for hyphen #30724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add recipe for hyphen #30724
Conversation
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I am willing to maintain this package |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Not sure how to deal with this, as the upstream source for tarballs is sourceforge: https://sourceforge.net/projects/hunspell/ Currently pointing to a sourceforge mirror (https://netcologne.dl.sourceforge.net) |
@conda-forge-admin, please ping team @conda-forge/help-c-cpp |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/staged-recipes and so here I am doing that. |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
recipes/hyphen/recipe.yaml
Outdated
skip: win | ||
script: | ||
- if: osx and arm64 | ||
then: echo 'echo arm-apple-darwin' > config.sub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually don't run osx + arm64 configuration in the staged recipes so this could be removed for now.
Also, if the config.sub
needs updating, we might be able to use this from https://conda-forge.org/blog/2020/10/29/macos-arm64/#how-to-add-a-osx-arm64-build-to-a-feedstock
For autotools package, add the following to recipe/meta.yaml
,
requirements:
build:
- gnuconfig # [unix]
and to recipe/build.sh
,
# Get an updated config.sub and config.guess
cp $BUILD_PREFIX/share/gnuconfig/config.* .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped osx + arm64
looks good overall! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).