Skip to content

Add recipe for hyphen #30724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

haecker-felix
Copy link
Contributor

@haecker-felix haecker-felix commented Aug 5, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

github-actions bot commented Aug 5, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/hyphen/recipe.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: Hofer-Julian. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/hyphen/recipe.yaml) and found it was in an excellent condition.

@Hofer-Julian
Copy link
Contributor

I am willing to maintain this package

Copy link
Contributor

github-actions bot commented Aug 5, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@haecker-felix
Copy link
Contributor Author

Source is from official source.

Not sure how to deal with this, as the upstream source for tarballs is sourceforge:

https://sourceforge.net/projects/hunspell/

Currently pointing to a sourceforge mirror (https://netcologne.dl.sourceforge.net)

@haecker-felix
Copy link
Contributor Author

@conda-forge-admin, please ping team @conda-forge/help-c-cpp

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Copy link
Contributor

github-actions bot commented Aug 5, 2025

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

skip: win
script:
- if: osx and arm64
then: echo 'echo arm-apple-darwin' > config.sub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually don't run osx + arm64 configuration in the staged recipes so this could be removed for now.

Also, if the config.sub needs updating, we might be able to use this from https://conda-forge.org/blog/2020/10/29/macos-arm64/#how-to-add-a-osx-arm64-build-to-a-feedstock

For autotools package, add the following to recipe/meta.yaml,

requirements:
  build:
    - gnuconfig   # [unix]

and to recipe/build.sh,

# Get an updated config.sub and config.guess
cp $BUILD_PREFIX/share/gnuconfig/config.* .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped osx + arm64

@wolfv
Copy link
Member

wolfv commented Aug 8, 2025

looks good overall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants