Replace deprecated Application::add() and enhance ParallelExec#1186
Open
humanik wants to merge 2 commits intoconsolidation:5.xfrom
Open
Replace deprecated Application::add() and enhance ParallelExec#1186humanik wants to merge 2 commits intoconsolidation:5.xfrom
humanik wants to merge 2 commits intoconsolidation:5.xfrom
Conversation
Symfony Console deprecated the add() method in favor of addCommand(). Update all usages across source and test files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request:
Summary
Replace deprecated Symfony Console
add()method withaddCommand()across all source and test files, and allow passingProcessinstances directly toParallelExec::process().Description
Commit 1: Allow passing Process instances directly to ParallelExec::process()
ParallelExec::process()now accepts aProcessinstance in addition to strings andCommandInterfaceobjects, giving users more flexibility when configuring parallel tasks.Commit 2: Replace deprecated Application::add() with addCommand()
Application::add()in favor ofaddCommand(). All usages acrossApplication.php,Robo.php,Runner.php, and test files have been updated accordingly.