Replace deprecated Application::add() and enhance ParallelExec

src/Application.php

@@ -56,7 +56,7 @@ public function addInitRoboFileCommand($roboFile, $roboClass)
             );
             $output->writeln("<comment>  Edit this file to add your commands! </comment>");
         });
-        $this->add($createRoboFile);
+        $this->addCommand($createRoboFile);
     }
 
     /**
@@ -71,6 +71,6 @@ public function addSelfUpdateCommand($repository = null)
             return;
         }
         $selfUpdateCommand = new \SelfUpdate\SelfUpdateCommand($this->getName(), $this->getVersion(), $repository);
-        $this->add($selfUpdateCommand);
+        $this->addCommand($selfUpdateCommand);
     }
 }

src/Robo.php

@@ -547,15 +547,15 @@ protected static function registerSingle($app, $handler)
         // If the instance is a Symfony Command, register it with
         // the application
         if ($instance instanceof Command) {
-            $app->add($instance);
+            $app->addCommand($instance);
             return $instance;
         }
 
         // Register commands for all of the public methods in the RoboFile.
         $commandFactory = $container->get('commandFactory');
         $commandList = $commandFactory->createCommandsFromClass($instance);
         foreach ($commandList as $command) {
-            $app->add($command);
+            $app->addCommand($command);
         }
         return $instance;
     }

src/Runtime/Runner.php

@@ -353,7 +353,7 @@ public function registerCommandClass($app, $commandClass)
         $commandFactory = $container->get('commandFactory');
         $commandList = $commandFactory->createCommandsFromClass($roboCommandFileInstance);
         foreach ($commandList as $command) {
-            $app->add($command);
+            $app->addCommand($command);
         }
         return $roboCommandFileInstance;
     }

src/Task/Base/ParallelExec.php

@@ -84,12 +84,17 @@ public function printed($isPrinted = true)
     }
 
     /**
-     * @param string|\Robo\Contract\CommandInterface $command
+     * @param string|\Robo\Contract\CommandInterface|Process $command
      *
      * @return $this
      */
     public function process($command)
     {
+        if ($command instanceof Process) {
+            $this->processes[] = $command;
+            return $this;
+        }
+
         // TODO: Symfony 4 requires that we supply the working directory.
         $this->processes[] = Process::fromShellCommandline($this->receiveCommand($command), getcwd());
         return $this;

tests/integration/RoboFileTest.php

@@ -35,7 +35,7 @@ public function setUp(): void
         $this->roboCommandFileInstance->setBuilder($builder);
         $commandList = $this->commandFactory->createCommandsFromClass($this->roboCommandFileInstance);
         foreach ($commandList as $command) {
-            $this->app->add($command);
+            $this->app->addCommand($command);
         }
     }
 

tests/unit/ApplicationTest.php

@@ -39,7 +39,7 @@ protected function _before()
         $this->roboCommandFileInstance->setBuilder($builder);
         $commandList = $this->commandFactory->createCommandsFromClass($this->roboCommandFileInstance);
         foreach ($commandList as $command) {
-            $this->app->add($command);
+            $this->app->addCommand($command);
         }
     }