Skip to content

testutil: bump up GolangImage to 1.23 #4215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

testutil: bump up GolangImage to 1.23 #4215

wants to merge 1 commit into from

Conversation

AkihiroSuda
Copy link
Member

Fix #4214

@AkihiroSuda
testutil: bump up GolangImage to 1.23
fd84535 
Fix issue 4214

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda added this to the v2.1.0 milestone May 8, 2025
@AkihiroSuda AkihiroSuda added priority/high area/ci e.g., CI failure labels May 8, 2025
@AkihiroSuda AkihiroSuda requested a review from ktock May 8, 2025 05:15
fahedouch
fahedouch approved these changes May 8, 2025
View reviewed changes
Copy link
Member

@fahedouch fahedouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented May 8, 2025 •
edited
Loading

https://github.com/containerd/nerdctl/actions/runs/14898775012/job/41850663565?pr=4215

???


=== FAIL: cmd/nerdctl/container TestRunWithLogBinary (re-run 2) (0.96s)
    testutil.go:598: buildkitHost="unix:///run/buildkit-nerdctl-test/buildkitd.sock"
    container_run_test.go:540: assertion failed: res.ExitCode is not exitCode: 
        Command:  /usr/local/bin/nerdctl --namespace=nerdctl-test build /tmp/TestRunWithLogBinary3394165887/001 --output type=local,src=/go/src/logger/logger,dest=/tmp/TestRunWithLogBinary3394165887/002
        ExitCode: 1
        Error:    exit status 1
        Stdout:   
        Stderr:   #1 [internal] load build definition from Dockerfile
        #1 transferring dockerfile: 1.32kB done
        #1 WARN: NoEmptyContinuation: Empty continuation line (line 48)
        #1 WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 2)
        #1 DONE 0.0s
        
        #2 [internal] load metadata for ghcr.io/stargz-containers/golang:1.23-org
        #2 DONE 0.1s
        
        #3 [internal] load .dockerignore
        #3 transferring context: 2B done
        #3 DONE 0.0s
        
        #4 [builder 1/8] FROM ghcr.io/stargz-containers/golang:1.23-org@sha256:e36fd3af78f13fb7fd27a16ec62370968ecbe113c1dd026c188162109b34c1a3
        #4 resolve ghcr.io/stargz-containers/golang:1.23-org@sha256:e36fd3af78f13fb7fd27a16ec62370968ecbe113c1dd026c188162109b34c1a3 0.0s done
        #4 DONE 0.0s
        
        #5 [builder 2/8] WORKDIR /go/src/
        #5 CACHED
        
        #6 [builder 3/8] RUN mkdir -p logger
        #6 CACHED
        
        #7 [builder 4/8] WORKDIR /go/src/logger
        #7 CACHED
        
        #8 [builder 5/8] RUN echo '	package main \n	\n	import ( \n	"bufio" \n	"context" \n	"fmt" \n	"io" \n	"os" \n	"path/filepath" \n	"sync" \n	\n	"github.com/containerd/containerd/v2/core/runtime/v2/logging"\n	)\n	func main() {\n		logging.Run(log)\n	}\n	func log(ctx context.Context, config *logging.Config, ready func() error) error {\n		var wg sync.WaitGroup \n		wg.Add(2) \n		// forward both stdout and stderr to temp files \n		go copy(&wg, config.Stdout, config.ID, "stdout") \n		go copy(&wg, config.Stderr, config.ID, "stderr") \n		// signal that we are ready and setup for the container to be started \n		if err := ready(); err != nil { \n		return err \n		} \n		wg.Wait() \n		return nil \n	}\n	\n	func copy(wg *sync.WaitGroup, r io.Reader, id string, kind string) { \n		f, _ := os.Create(filepath.Join(os.TempDir(), fmt.Sprintf("%s_%s.log", id, kind))) \n		defer f.Close() \n		defer wg.Done() \n		s := bufio.NewScanner(r) \n		for s.Scan() { \n			f.WriteString(s.Text()) \n		} \n	}\n' >> main.go
        #8 CACHED
        
        #9 [builder 6/8] RUN go mod init
        #9 CACHED
        
        #10 [builder 7/8] RUN go mod tidy
        #10 0.363 runtime: lfstack.push invalid packing: node=0xff8ee894f980 cnt=0x1 packed=0xff8ee894f9800001 -> node=0xffffff8ee894f980
        #10 0.363 fatal error: lfstack.push
        #10 0.366 
        #10 0.366 runtime stack:
        #10 0.366 runtime.throw({0xaf743b?, 0x0?})
        #10 0.367 	runtime/panic.go:1067 +0x48 fp=0xc000093f08 sp=0xc000093ed8 pc=0x4715e8
        #10 0.367 runtime.(*lfstack).push(0xff8ee8c00918?, 0xc000007500?)
        #10 0.367 	runtime/lfstack.go:29 +0x125 fp=0xc000093f48 sp=0xc000093f08 pc=0x40ee25
        #10 0.367 runtime.(*spanSetBlockAlloc).free(...)
        #10 0.367 	runtime/mspanset.go:322
        #10 0.367 runtime.(*spanSet).reset(0xfe9480)
        #10 0.367 	runtime/mspanset.go:264 +0x79 fp=0xc000093f78 sp=0xc000093f48 pc=0x433599
        #10 0.367 runtime.finishsweep_m()
        #10 0.367 	runtime/mgcsweep.go:257 +0x8d fp=0xc000093fb8 sp=0xc000093f78 pc=0x4262ad
        #10 0.367 runtime.gcStart.func2()
        #10 0.367 	runtime/mgc.go:723 +0xf fp=0xc000093fc8 sp=0xc000093fb8 pc=0x469ccf
        #10 0.367 runtime.systemstack(0x0)
        #10 0.367 	runtime/asm_amd64.s:514 +0x4a fp=0xc000093fd8 sp=0xc000093fc8 pc=0x4777ea
        #10 0.367 
        #10 0.367 goroutine 34 gp=0xc0002bc000 m=5 mp=0xc000059508 [running]:
        #10 0.367 runtime.systemstack_switch()
        #10 0.367 	runtime/asm_amd64.s:479 +0x8 fp=0xc0001f10c8 sp=0xc0001f10b8 pc=0x477788
        #10 0.367 runtime.gcStart({0xff8f3075b108?, 0x200000059?, 0x0?})
        #10 0.368 	runtime/mgc.go:722 +0x35c fp=0xc0001f1198 sp=0xc0001f10c8 pc=0x41b21c
        #10 0.368 runtime.mallocgc(0x1000, 0xa24c80, 0x1)
        #10 0.368 	runtime/malloc.go:1304 +0x934 fp=0xc0001f1238 sp=0xc0001f1198 pc=0x46c794
        #10 0.368 runtime.makeslice(0xa45140?, 0xa45140?, 0x7?)
        #10 0.369 	runtime/slice.go:116 +0x49 fp=0xc0001f1260 sp=0xc0001f1238 pc=0x473b09
        #10 0.369 bufio.NewReaderSize(...)
        #10 0.369 	bufio/bufio.go:54
        #10 0.369 bufio.NewReader(...)
        #10 0.369 	bufio/bufio.go:60
        #10 0.369 cmd/go/internal/modindex.newImportReader({0xc0003066c0, 0x24}, {0xc14000, 0xc000286488?})
        #10 0.369 	cmd/go/internal/modindex/build_read.go:39 +0x9e fp=0xc0001f12f8 sp=0xc0001f1260 pc=0x841f5e
        #10 0.369 cmd/go/internal/modindex.readGoInfo({0xc14000?, 0xc000286488?}, 0xc0000c9080)
        #10 0.369 	cmd/go/internal/modindex/build_read.go:402 +0x50 fp=0xc0001f1490 sp=0xc0001f12f8 pc=0x842f30
        #10 0.369 cmd/go/internal/modindex.getFileInfo({0xc000028a20, 0x15}, {0xc00039df96, 0xe}, 0xc00009fac0)
        #10 0.369 	cmd/go/internal/modindex/build.go:449 +0x4bc fp=0xc0001f1550 sp=0xc0001f1490 pc=0x83ee1c
        #10 0.369 cmd/go/internal/modindex.importRaw({0xc000028048, 0x11}, {0xc000028102, 0x3})
        #10 0.369 	cmd/go/internal/modindex/scan.go:220 +0x3f1 fp=0xc0001f1770 sp=0xc0001f1550 pc=0x84cf11
        #10 0.369 cmd/go/internal/modindex.indexPackage({0xc000028048, 0x11}, {0xc0000280f0, 0x15})
        #10 0.369 	cmd/go/internal/modindex/scan.go:86 +0x65 fp=0xc0001f17a8 sp=0xc0001f1770 pc=0x84c7e5
        #10 0.369 cmd/go/internal/modindex.openIndexPackage.func1()
        #10 0.369 	cmd/go/internal/modindex/read.go:215 +0x13e fp=0xc0001f18a0 sp=0xc0001f17a8 pc=0x84539e
        #10 0.369 cmd/go/internal/par.(*ErrCache[...]).Do.func1()
        #10 0.369 	cmd/go/internal/par/work.go:119 +0x13 fp=0xc0001f18b0 sp=0xc0001f18a0 pc=0x84f4f3
        #10 0.369 cmd/go/internal/par.(*Cache[...]).Do(0xc1ebc0, {{0xc000028048, 0x11}, {0xc0000280f0, 0x15}}, 0xc0001f1958)
        #10 0.369 	cmd/go/internal/par/work.go:160 +0x11b fp=0xc0001f1920 sp=0xc0001f18b0 pc=0x84f6db
        #10 0.369 cmd/go/internal/par.(*ErrCache[...]).Do(0xc00003e140?, {{0xc000028048, 0x11}, {0xc0000280f0, 0x15}}, 0x0?)
        #10 0.369 	cmd/go/internal/par/work.go:118 +0x46 fp=0xc0001f1980 sp=0xc0001f1920 pc=0x84f4a6
        #10 0.369 cmd/go/internal/modindex.openIndexPackage({0xc000028048?, 0xc00003e140?}, {0xc0000280f0?, 0xc00003e140?})
        #10 0.369 	cmd/go/internal/modindex/read.go:205 +0x98 fp=0xc0001f1a10 sp=0xc0001f1980 pc=0x845218
        #10 0.369 cmd/go/internal/modindex.GetPackage({0xc000028048, 0x11}, {0xc0000280f0, 0x15})
        #10 0.369 	cmd/go/internal/modindex/read.go:142 +0x14d fp=0xc0001f1a58 sp=0xc0001f1a10 pc=0x844ccd
        #10 0.369 cmd/go/internal/modindex.IsStandardPackage({0xc000030080, 0xd}, {0xaf16c6, 0x2}, {0xc00017ae7c, 0x3})
        #10 0.369 	cmd/go/internal/modindex/read.go:673 +0x20a fp=0xc0001f1b28 sp=0xc0001f1a58 pc=0x84988a
        #10 0.369 cmd/go/internal/modload.importFromModules({0xc1a290, 0xfefbe0}, {0xc00017ae7c, 0x3}, 0xc0001e40f0, 0x0, 0x0)
        #10 0.369 	cmd/go/internal/modload/import.go:301 +0x34a fp=0xc0001f1e50 sp=0xc0001f1b28 pc=0x86adca
        #10 0.369 cmd/go/internal/modload.(*loader).load(0xc0001a20e0, {0xc1a290, 0xfefbe0}, 0xc000388820)
        #10 0.369 	cmd/go/internal/modload/load.go:1852 +0xa5 fp=0xc0001f1f30 sp=0xc0001f1e50 pc=0x887d45
        #10 0.369 cmd/go/internal/modload.(*loader).pkg.func1.1()
        #10 0.369 	cmd/go/internal/modload/load.go:1665 +0x25 fp=0xc0001f1f60 sp=0xc0001f1f30 pc=0x886a05
        #10 0.369 cmd/go/internal/par.(*Queue).Add.func1()
        #10 0.369 	cmd/go/internal/par/queue.go:58 +0x5c fp=0xc0001f1fe0 sp=0xc0001f1f60 pc=0x5dc25c
        #10 0.369 runtime.goexit({})
        #10 0.369 	runtime/asm_amd64.s:1700 +0x1 fp=0xc0001f1fe8 sp=0xc0001f1fe0 pc=0x479621
        #10 0.369 created by cmd/go/internal/par.(*Queue).Add in goroutine 1
        #10 0.369 	cmd/go/internal/par/queue.go:56 +0x1d3
...

@AkihiroSuda
Copy link
Member Author

Are we accidentally cross-compiling an amd64 binary on arm64? 🤔

@AkihiroSuda
Copy link
Member Author

An alternative PR:

@AkihiroSuda AkihiroSuda removed this from the v2.1.0 milestone May 8, 2025
@AkihiroSuda AkihiroSuda mentioned this pull request May 8, 2025
Merged
@fahedouch
Copy link
Member

@AkihiroSuda please rebase

@apostasie
Copy link
Contributor

apostasie commented May 8, 2025 •
edited
Loading

https://github.com/containerd/nerdctl/actions/runs/14898775012/job/41850663565?pr=4215

???

stargz-containers rarely publishes multi platform images.

This specifically https://github.com/stargz-containers/image-ci/pkgs/container/golang/351114451?tag=1.23-org is an amd64-only image.

@apostasie apostasie mentioned this pull request May 8, 2025
Merged
@apostasie
Copy link
Contributor

Docker failure is #4219

@AkihiroSuda
Copy link
Member Author

Cc @ktock

@AkihiroSuda AkihiroSuda marked this pull request as draft May 9, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fahedouch fahedouch fahedouch approved these changes

@ktock ktock Awaiting requested review from ktock

Assignees
No one assigned
Labels
area/ci e.g., CI failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI failure: package slices is not in GOROOT
3 participants
@AkihiroSuda @fahedouch @apostasie