Skip to content

TestRunWithLogBinary: workaround for "package slices is not in GOROOT" #4216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

TestRunWithLogBinary: workaround for "package slices is not in GOROOT" #4216

merged 1 commit into from
May 8, 2025

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented May 8, 2025 •
edited
Loading

Fix #4214 as a quick workaround

This can be reverted after merging:

@AkihiroSuda
TestRunWithLogBinary: workaround for "package slices is not in GOROOT"
9a06958 
Fix issue 4214 as a quick workaround

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda added this to the v2.1.0 milestone May 8, 2025
@AkihiroSuda AkihiroSuda added priority/high area/ci e.g., CI failure labels May 8, 2025
@AkihiroSuda AkihiroSuda mentioned this pull request May 8, 2025
Closed
@AkihiroSuda AkihiroSuda requested a review from ktock May 8, 2025 08:28
@AkihiroSuda
Copy link
Member Author

Docker failure is irrelevant

@AkihiroSuda AkihiroSuda requested a review from fahedouch May 8, 2025 09:21
@ktock ktock merged commit 10555b2 into containerd:main May 8, 2025
93 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktock ktock ktock approved these changes

@fahedouch fahedouch Awaiting requested review from fahedouch

Assignees
No one assigned
Labels
area/ci e.g., CI failure priority/high
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

CI failure: package slices is not in GOROOT
2 participants
@AkihiroSuda @ktock