Fix copying of non-Buildah Zstd images with --preserve-digests #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ A new PR has been created in buildah to vendor these changes: containers/buildah#6536 |
mtrmac
changed the title
Format conversions should have been rejected earlier; this conceptually means something else has probably changed. That's not _actually_ reliably true at this point because determineListConversion does not take cannotModifyManifestListReason into account, but that's a different bug, to be fixed some other time. Signed-off-by: Miloslav Trmač <[email protected]>
In that case, just copy the image as is, giving up on enabling the zstd prioritization. Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
force-pushed
the
zstd-annotation
branch
from
6ce3ae5 to
ca62de1
Compare
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes containers/skopeo#2627 .
See individual commit messages for details; note the last comment adding FIXMEs for unfixed bugs.