test(pods): update PodsExec tests to use testify and improve readability #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cali0707
reviewed
Oct 23, 2025
pkg/mcp/pods_exec_test.go
Outdated
| })) | ||
| s.InitMcpClient() | ||
|
|
||
| s.Run("pods_exec(name=pod-to-exec, command=[ls -l])", func() { |
There was a problem hiding this comment.
nit, can we call out that namespace="" here - I liked how explicit the old test was, especially since that is the key for why the tool call fails
There was a problem hiding this comment.
especially since that is the key for why the tool call fails
Absolutely, I added more clarity to the description too.
In this case, the tool call won't fail and will be executed in the configured namespace.
Given your comment, the test description was not doing a great job.
There was a problem hiding this comment.
Looking now, I understand what's supposed to happen - thanks!
Signed-off-by: Marc Nuri <[email protected]>
Signed-off-by: Marc Nuri <[email protected]>
manusa
force-pushed
the
test/pods-exec
branch
from
6d7e592 to
3de9fab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will facilitate #385