topology-aware: avoid slicing busy shared pools empty #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
force-pushed
the
fixes/dont-slice-busy-pools-empty
branch
from
97d4ca0 to
9cdd695
Compare
klihub
force-pushed
the
fixes/dont-slice-busy-pools-empty
branch
2 times, most recently
from
ee614f0 to
8e7b615
Compare
askervin
reviewed
Dec 3, 2025
Update allocation to account an extra milliCPU capacity if a node has BestEffort containers assigned to the shared pool of the node or any of its children. When slicing exclusive CPUs from a shared pool, make sure we don't slice any of the busy shared pools empty. Signed-off-by: Krisztian Litkey <[email protected]>
Add a test case from Antti Kervinen <[email protected]> for testing that busy shared CPU pools are not sliced empty. Co-authored-by: Antti Kervinen <[email protected]> Signed-off-by: Krisztian Litkey <[email protected]>
Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
fixes/dont-slice-busy-pools-empty
branch
from
8e7b615 to
ca9beb1
Compare
This was referenced Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the topology-aware policy CPU accounting and allocation algorithm, to
A shared pool is considered busy if it has at least one best-effort or zero-cpu-req. burstable container assigned to it or any of its children.