-
Notifications
You must be signed in to change notification settings - Fork 15
Allow skipping TLS verification #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
pkg/utils/podman.go
Outdated
"github.com/containers/podman/v5/pkg/bindings/images" | ||
"github.com/containers/podman/v5/pkg/domain/entities/types" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the empty line (probably it will require reordering the import list)
this is not really a tls-related change, do you mind doing it on its own commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, will do. Do you mean keep the same commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant moving this import lines on a different commit that the rest of the changes, like:
commit 1: Moving the import lines
commit 2: All the TLSverify-related changes
pkg/utils/podman.go
Outdated
"github.com/containers/podman/v5/pkg/bindings" | ||
"github.com/containers/podman/v5/pkg/bindings/images" | ||
"github.com/containers/podman/v5/pkg/domain/entities/types" | ||
|
||
"github.com/containers/podman/v5/pkg/bindings" | ||
"github.com/containers/podman/v5/pkg/machine" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I was not clear. I meant to move this import lines:
"encoding/json"
"errors"
"fmt"
"github.com/containers/podman/v5/pkg/bindings/images" <---
"github.com/containers/podman/v5/pkg/domain/entities/types" <---
"os"
"os/exec"
to
"github.com/containers/podman/v5/pkg/bindings"
"github.com/containers/podman/v5/pkg/bindings/images" <---
"github.com/containers/podman/v5/pkg/domain/entities/types" <---
"github.com/containers/podman/v5/pkg/machine
in a single commit, not to move them in the first commit and remove the empty and line sort them in a new commit
So, moving these two lines to the correct import "block" (as you did here) should be in one single commit.
So, one commit should not fix a previous one in the same PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, that's what I was wondering earlier.
Added a --tls-verify flag to the run command which allows skipping TLS verification when connecting to registries. Signed-off-by: Hariharan <[email protected]>
Added a
--tls-verify
flag to the run command which allows skipping TLS verification when connecting to registries.Fixes #87