fix: dependson servicecompletedsuccessfully isnt always followed#1413
Closed
OnlyTerp wants to merge 2 commits intocontainers:mainfrom
Closed
fix: dependson servicecompletedsuccessfully isnt always followed#1413OnlyTerp wants to merge 2 commits intocontainers:mainfrom
OnlyTerp wants to merge 2 commits intocontainers:mainfrom
Conversation
added 2 commits
March 7, 2026 04:37
Fixes #1330 Signed-off-by: roberthallers <roberthallers@users.noreply.github.com>
…ed-blocks Extract the container state polling loop into a dedicated helper function to reduce nesting depth in check_dep_conditions below pylint's threshold. No behavioral changes. Signed-off-by: roberthallers <roberthallers@users.noreply.github.com>
p12tic
reviewed
Mar 9, 2026
| break | ||
| except subprocess.CalledProcessError: | ||
| pass | ||
| log.debug( |
Collaborator
There was a problem hiding this comment.
We should make this log message appear at most once a second.
p12tic
requested changes
Mar 9, 2026
Collaborator
p12tic
left a comment
p12tic
left a comment
There was a problem hiding this comment.
Looks good to me, but please add a newsfragment and an integration test.
Collaborator
|
Also please check spelling in PR title and commit messages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1330
Problem
Describe the bug
The
depends_on:attribute with value "service_completed_successfully" isn't always honored, and containers may start out of their desired order.To Reproduce
Changes
This PR addresses the issue by:
Testing
Checklist