Skip to content

fix: dependson servicecompletedsuccessfully isnt always followed #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OnlyTerp wants to merge 2 commits into from
Closed

fix: dependson servicecompletedsuccessfully isnt always followed #1413

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f7aad5
fix: dependson servicecompletedsuccessfully isnt always followed
Mar 7, 2026
84b0f31
fix: extract _wait_containers_started to resolve pylint too-many-nest…
Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions podman_compose.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3311,6 +3311,33 @@ def get_excluded(
return excluded


async def _wait_containers_started(compose: PodmanCompose, containers: list) -> None:
"""Poll until all containers have left the 'created' state.

For service_completed_successfully (--condition=stopped), podman wait may return
immediately if the container hasn't transitioned out of "created" state yet —
i.e. podman start was called but the container hasn't actually begun running.
We poll until all dependency containers have left the "created" state before
invoking podman wait, eliminating the race condition.
See: https://github.com/containers/podman-compose/issues/1330
"""
while True:
try:
statuses_raw = await compose.podman.output(
[], "inspect", ["--format={{.State.Status}}"] + containers
)
statuses = statuses_raw.decode().split()
if all(s != "created" for s in statuses if s):
break
except subprocess.CalledProcessError:
pass
log.debug(
Copy link
Collaborator

@p12tic p12tic Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this log message appear at most once a second.

"Waiting for dependency containers to leave 'created' state: %s",
', '.join(containers),
)
await asyncio.sleep(0.05)


async def check_dep_conditions(compose: PodmanCompose, deps: set) -> None:
"""Enforce that all specified conditions in deps are met"""
if not deps:
Expand Down Expand Up @@ -3338,6 +3365,9 @@ async def check_dep_conditions(compose: PodmanCompose, deps: set) -> None:
deps_cd.extend(compose.container_names_by_service[d.name])

if deps_cd:
if condition == ServiceDependencyCondition.STOPPED:
await _wait_containers_started(compose, deps_cd)

# podman wait will return always with a rc -1.
while True:
try:
Expand Down