-
Notifications
You must be signed in to change notification settings - Fork 1
88 dev adding models for exa #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…trol-toolbox/OptimalControlProblems.jl into 88-dev-adding-models-for-exa
…nto 88-dev-adding-models-for-exa
|
@jbcaillau I am working on #139 |
|
@ocots what is this |
Good catch. I don't know. Does it make sense to let the first component free at the final time. I have removed the @constraint(model, x2[N + 1] == xf[2])
@constraint(model, x3[N + 1] == xf[3])
@constraint(model, x4[N + 1] == xf[4])instead of @constraint(model, x2[N + 1] == xf[1])
@constraint(model, x3[N + 1] == xf[2])
@constraint(model, x4[N + 1] == xf[3]) |
…-problems Configurable problems
…-exa-olivier Add tests
|
@jbcaillau There is sometimes a difference between my local CI and on runners. Here, there is a fail for the space shuttle problem: https://github.com/control-toolbox/OptimalControlProblems.jl/actions/runs/17739285652/job/50412586297?pr=137#step:4:2976 What is strange, is that there is a fail for the "quick" test but not for the "solution" test. Both make the same calls to the solvers with the same init and parameters. The problem seems to come from:
|
jbcaillau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocots nice job. a lot of things, bravo 👍🏽
| ########## OptimalControl_s ########## | ||
| docp = OptimalControlProblems.eval(Symbol(f, :_s))(OptimalControlBackend(), :madnlp, :exa; grid_size=grid_size) | ||
| nlp = nlp_model(docp) | ||
| nlp_sol = madnlp(nlp; kwargs_madnlp...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocots i see the call here, don't see anything special
|
@ocots important: be sure to use Mumps for the linear solver on CPU, both for Ipopt / MadNLP and adnlp / exa. |
This is the case. |
|
@jbcaillau We will need to add some documentation about the |
close #88