Skip to content

Conversation

@jbcaillau
Copy link
Member

close #88

@jbcaillau jbcaillau linked an issue Sep 5, 2025 that may be closed by this pull request
@github-actions github-actions bot requested a review from ocots September 5, 2025 17:41
@ocots
Copy link
Member

ocots commented Sep 8, 2025

@jbcaillau I am working on #139

@jbcaillau
Copy link
Member Author

@ocots what is this NaN in target xf for the steering use case?

@ocots
Copy link
Member

ocots commented Sep 10, 2025

@ocots what is this NaN in target xf for the steering use case?

Good catch. I don't know. Does it make sense to let the first component free at the final time. I have removed the NaN for the other models. Actually I think that Yassin wrote a NaN to have in JuMP:

@constraint(model, x2[N + 1] == xf[2])
@constraint(model, x3[N + 1] == xf[3])
@constraint(model, x4[N + 1] == xf[4])

instead of

@constraint(model, x2[N + 1] == xf[1])
@constraint(model, x3[N + 1] == xf[2])
@constraint(model, x4[N + 1] == xf[3])

@ocots
Copy link
Member

ocots commented Sep 15, 2025

@jbcaillau There is sometimes a difference between my local CI and on runners.

Here, there is a fail for the space shuttle problem: https://github.com/control-toolbox/OptimalControlProblems.jl/actions/runs/17739285652/job/50412586297?pr=137#step:4:2976

What is strange, is that there is a fail for the "quick" test but not for the "solution" test. Both make the same calls to the solvers with the same init and parameters.

The problem seems to come from:

Copy link
Member Author

@jbcaillau jbcaillau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocots nice job. a lot of things, bravo 👍🏽

########## OptimalControl_s ##########
docp = OptimalControlProblems.eval(Symbol(f, :_s))(OptimalControlBackend(), :madnlp, :exa; grid_size=grid_size)
nlp = nlp_model(docp)
nlp_sol = madnlp(nlp; kwargs_madnlp...)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocots i see the call here, don't see anything special

@jbcaillau
Copy link
Member Author

@ocots important: be sure to use Mumps for the linear solver on CPU, both for Ipopt / MadNLP and adnlp / exa.

@ocots ocots marked this pull request as ready for review September 25, 2025 13:02
@ocots
Copy link
Member

ocots commented Sep 25, 2025

@ocots important: be sure to use Mumps for the linear solver on CPU, both for Ipopt / MadNLP and adnlp / exa.

This is the case.

@ocots ocots merged commit a09a56f into main Sep 25, 2025
4 checks passed
@ocots ocots deleted the 88-dev-adding-models-for-exa branch September 25, 2025 13:05
@ocots
Copy link
Member

ocots commented Sep 25, 2025

@jbcaillau We will need to add some documentation about the _s problems. There is no mention of them for the moment.

@ocots ocots mentioned this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dev] Adding models for exa

3 participants