Skip to content

Conversation

@Otard95
Copy link

@Otard95 Otard95 commented Mar 18, 2024

I originally came across this when release-please didn't pick up one of our commits. Eventually I tracked it down to this package. I'm creating a PR, mostly to provide the failing test showing the issue. I minimized the test as much as possible, here's a snippet of the original text from the commit that failed to parse, if that's helpful:

    ```graphql
@​link(url: "https://specs.apollo.dev/federation/v2.6", import:
[..., "@​policy"])
    ```

The code block is a result of the text in this PR apollographql/federation#2818 ending up in one of our Renovate PR's and subsequently commit body.

@Otard95 Otard95 changed the title Fails to parse when body includes something that looks like a scope Fails to parse when body includes something that looks like a scope with new line Mar 18, 2024
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approval is just to kick the CI into action. If this doesn't do the trick I will see about pulling this down to run locally.

EDIT: yep, committing that white space removal was enough to make the "approve and run actions" button show up.

maybe removing the whitespace here will kick off the CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants